don't look up IFacing (twice!) every frame for every actor with RenderUnit; fixes #1054

2011-07-19 18:39:45 +12:00
parent 2797ea72cb
commit 7429c8ef89
1 changed files with 8 additions and 1 deletions
--- a/OpenRA.Mods.RA/Render/RenderUnit.cs
+++ b/OpenRA.Mods.RA/Render/RenderUnit.cs
@@ -21,8 +21,15 @@ namespace OpenRA.Mods.RA.Render

 	public class RenderUnit : RenderSimple
 	{
+		static Func<int> MakeFacingFunc(Actor self)
+		{
+			var facing = self.TraitOrDefault<IFacing>();
+			if (facing == null) return () => 0;
+			return () => facing.Facing;
+		}
+
 		public RenderUnit(Actor self)
-			: base(self, () => self.HasTrait<IFacing>() ? self.Trait<IFacing>().Facing : 0)
+			: base(self, MakeFacingFunc(self))
 		{
 			anim.PlayRepeating("idle");
 		}