From 75a3bb4f0bff6c518247cc52eebe25ae61eaaac1 Mon Sep 17 00:00:00 2001 From: reaperrr Date: Sun, 14 Mar 2021 14:09:58 +0100 Subject: [PATCH] CellIsEvaluating perf optimization If an actor has Mobile, it implements IOccupySpace so we can use OccupiesSpace to save a trait look-up. --- OpenRA.Mods.Common/Activities/Move/Move.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OpenRA.Mods.Common/Activities/Move/Move.cs b/OpenRA.Mods.Common/Activities/Move/Move.cs index 140978eb0f..54a8dee11c 100644 --- a/OpenRA.Mods.Common/Activities/Move/Move.cs +++ b/OpenRA.Mods.Common/Activities/Move/Move.cs @@ -341,7 +341,7 @@ namespace OpenRA.Mods.Common.Activities { foreach (var actor in self.World.ActorMap.GetActorsAt(cell)) { - var move = actor.TraitOrDefault(); + var move = actor.OccupiesSpace as Mobile; if (move == null || !move.IsTraitEnabled() || !move.IsLeaving()) return false; }