epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

don't fetch IFacing unless we actually need it, in Attack

Browse Source
This commit is contained in:
Chris Forbes
2012-03-04 11:17:46 +13:00
parent 38b5a8d4f8
commit 75e32c0573
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
OpenRA.Mods.RA/Activities/Attack.cs
View File

@@ -51,7 +51,7 @@ namespace OpenRA.Mods.RA.Activities
protected virtual Activity InnerTick( Actor self, AttackBase attack ) protected virtual Activity InnerTick( Actor self, AttackBase attack )
{ {
if (IsCanceled) return NextActivity; if (IsCanceled) return NextActivity;
var facing = self.Trait<IFacing>();
if (!Target.IsValid) if (!Target.IsValid)
return NextActivity; return NextActivity;
@@ -70,6 +70,7 @@ namespace OpenRA.Mods.RA.Activities
} }
var desiredFacing = Util.GetFacing(Target.CenterLocation - self.CenterLocation, 0); var desiredFacing = Util.GetFacing(Target.CenterLocation - self.CenterLocation, 0);
var facing = self.Trait<IFacing>();
if (facing.Facing != desiredFacing) if (facing.Facing != desiredFacing)
return Util.SequenceActivities( new Turn( desiredFacing ), this ); return Util.SequenceActivities( new Turn( desiredFacing ), this );