Rewrite sequence linting / missing file handling.

- Distinguish between missing sequences and missing sprites
- Lint default sequences as well as maps
- Improved performance
- Correctly handle null images

OpenRA.Mods.Common/Traits/Buildings/RallyPoint.cs

@@ -24,10 +24,10 @@ namespace OpenRA.Mods.Common.Traits
 		[Desc("Width (in pixels) of the rallypoint line.")]
 		public readonly int LineWidth = 1;
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		public readonly string FlagSequence = "flag";
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		public readonly string CirclesSequence = "circles";
 
 		[Desc("Cursor to display when rally point can be set.")]

OpenRA.Mods.Common/Traits/Crates/CrateAction.cs

@@ -23,7 +23,7 @@ namespace OpenRA.Mods.Common.Traits
 		[Desc("Image containing the crate effect animation sequence.")]
 		public readonly string Image = "crate-effects";
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		[Desc("Animation sequence played when collected. Leave empty for no effect.")]
 		public readonly string Sequence = null;
 

OpenRA.Mods.Common/Traits/GainsExperience.cs

@@ -32,7 +32,7 @@ namespace OpenRA.Mods.Common.Traits
 		[Desc("Image for the level up sprite.")]
 		public readonly string LevelUpImage = null;
 
-		[SequenceReference("LevelUpImage")]
+		[SequenceReference("LevelUpImage", allowNullImage: true)]
 		[Desc("Sequence for the level up sprite. Needs to be present on LevelUpImage.")]
 		public readonly string LevelUpSequence = "levelup";
 

OpenRA.Mods.Common/Traits/Parachutable.cs

@@ -29,7 +29,7 @@ namespace OpenRA.Mods.Common.Traits
 		[Desc("Image where Ground/WaterCorpseSequence is looked up.")]
 		public readonly string Image = "explosion";
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		public readonly string GroundCorpseSequence = null;
 
 		[PaletteReference]
@@ -37,7 +37,7 @@ namespace OpenRA.Mods.Common.Traits
 
 		public readonly string GroundImpactSound = null;
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		public readonly string WaterCorpseSequence = null;
 
 		[PaletteReference]

OpenRA.Mods.Common/Traits/Render/WithDecoration.cs

@@ -23,7 +23,7 @@ namespace OpenRA.Mods.Common.Traits.Render
 		public readonly string Image = null;
 
 		[FieldLoader.Require]
-		[SequenceReference("Image", false, true)]
+		[SequenceReference("Image", allowNullImage: true)]
 		[Desc("Sequence used for this decoration (can be animated).")]
 		public readonly string Sequence = null;
 

OpenRA.Mods.Common/Traits/Render/WithIdleOverlay.cs

@@ -23,11 +23,11 @@ namespace OpenRA.Mods.Common.Traits.Render
 		[Desc("Image used for this decoration. Defaults to the actor's type.")]
 		public readonly string Image = null;
 
-		[SequenceReference("Image", false, true)]
+		[SequenceReference("Image", allowNullImage: true)]
 		[Desc("Animation to play when the actor is created.")]
 		public readonly string StartSequence = null;
 
-		[SequenceReference("Image", false, true)]
+		[SequenceReference("Image", allowNullImage: true)]
 		[Desc("Sequence name to use")]
 		public readonly string Sequence = "idle-overlay";
 

OpenRA.Mods.Common/Traits/Render/WithParachute.cs

@@ -25,15 +25,15 @@ namespace OpenRA.Mods.Common.Traits.Render
 		[Desc("The image that contains the parachute sequences.")]
 		public readonly string Image = null;
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		[Desc("Parachute opening sequence.")]
 		public readonly string OpeningSequence = null;
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		[Desc("Parachute idle sequence.")]
 		public readonly string Sequence = null;
 
-		[SequenceReference("Image")]
+		[SequenceReference("Image", allowNullImage: true)]
 		[Desc("Parachute closing sequence. Defaults to opening sequence played backwards.")]
 		public readonly string ClosingSequence = null;
 
@@ -49,7 +49,7 @@ namespace OpenRA.Mods.Common.Traits.Render
 		[Desc("The image that contains the shadow sequence for the paradropped unit.")]
 		public readonly string ShadowImage = null;
 
-		[SequenceReference("ShadowImage")]
+		[SequenceReference("ShadowImage", allowNullImage: true)]
 		[Desc("Paradropped unit's shadow sequence.")]
 		public readonly string ShadowSequence = null;
 

OpenRA.Mods.Common/Traits/SupportPowers/NukePower.cs

@@ -55,7 +55,7 @@ namespace OpenRA.Mods.Common.Traits
 		[Desc("Trail animation.")]
 		public readonly string TrailImage = null;
 
-		[SequenceReference("TrailImage")]
+		[SequenceReference("TrailImage", allowNullImage: true)]
 		[Desc("Loop a randomly chosen sequence of TrailImage from this list while this projectile is moving.")]
 		public readonly string[] TrailSequences = { };