Fix and enable SA1133, SA1134 style rules.

This commit is contained in:
Paul Chote
2019-05-23 18:43:21 +00:00
committed by abcdefg30
parent fbf9461890
commit 78a70be0d4
214 changed files with 1012 additions and 432 deletions

View File

@@ -28,12 +28,19 @@ namespace OpenRA.Mods.Cnc.Traits
[Desc("Ticks until returning after teleportation.")]
public readonly int Duration = 750;
[PaletteReference] public readonly string TargetOverlayPalette = TileSet.TerrainPaletteInternalName;
[PaletteReference]
public readonly string TargetOverlayPalette = TileSet.TerrainPaletteInternalName;
public readonly string OverlaySpriteGroup = "overlay";
[SequenceReference("OverlaySpriteGroup", true)] public readonly string ValidTileSequencePrefix = "target-valid-";
[SequenceReference("OverlaySpriteGroup")] public readonly string InvalidTileSequence = "target-invalid";
[SequenceReference("OverlaySpriteGroup")] public readonly string SourceTileSequence = "target-select";
[SequenceReference("OverlaySpriteGroup", true)]
public readonly string ValidTileSequencePrefix = "target-valid-";
[SequenceReference("OverlaySpriteGroup")]
public readonly string InvalidTileSequence = "target-invalid";
[SequenceReference("OverlaySpriteGroup")]
public readonly string SourceTileSequence = "target-select";
public readonly bool KillCargo = true;

View File

@@ -24,19 +24,25 @@ namespace OpenRA.Mods.Cnc.Traits
public readonly int RevealDelay = 0;
public readonly string DoorImage = "atek";
[SequenceReference("DoorImage")] public readonly string DoorSequence = "active";
[SequenceReference("DoorImage")]
public readonly string DoorSequence = "active";
[PaletteReference("DoorPaletteIsPlayerPalette")]
[Desc("Palette to use for rendering the launch animation")]
[PaletteReference("DoorPaletteIsPlayerPalette")] public readonly string DoorPalette = "player";
public readonly string DoorPalette = "player";
[Desc("Custom palette is a player palette BaseName")]
public readonly bool DoorPaletteIsPlayerPalette = true;
public readonly string SatelliteImage = "sputnik";
[SequenceReference("SatelliteImage")] public readonly string SatelliteSequence = "idle";
[SequenceReference("SatelliteImage")]
public readonly string SatelliteSequence = "idle";
[PaletteReference("SatellitePaletteIsPlayerPalette")]
[Desc("Palette to use for rendering the satellite projectile")]
[PaletteReference("SatellitePaletteIsPlayerPalette")] public readonly string SatellitePalette = "player";
public readonly string SatellitePalette = "player";
[Desc("Custom palette is a player palette BaseName")]
public readonly bool SatellitePaletteIsPlayerPalette = true;

View File

@@ -30,12 +30,15 @@ namespace OpenRA.Mods.Cnc.Traits
[Desc("Effect sequence sprite image")]
public readonly string Effect = "ionsfx";
[SequenceReference("Effect")]
[Desc("Effect sequence to display")]
[SequenceReference("Effect")] public readonly string EffectSequence = "idle";
public readonly string EffectSequence = "idle";
[PaletteReference] public readonly string EffectPalette = "effect";
[PaletteReference]
public readonly string EffectPalette = "effect";
[Desc("Which weapon to fire"), WeaponReference]
[WeaponReference]
[Desc("Which weapon to fire")]
public readonly string Weapon = "IonCannon";
public WeaponInfo WeaponInfo { get; private set; }