Fix and enable SA1133, SA1134 style rules.

This commit is contained in:
Paul Chote
2019-05-23 18:43:21 +00:00
committed by abcdefg30
parent fbf9461890
commit 78a70be0d4
214 changed files with 1012 additions and 432 deletions

View File

@@ -20,11 +20,13 @@ namespace OpenRA.Mods.Common.Traits.Render
[Desc("This actor has a death animation.")]
public class WithDeathAnimationInfo : ConditionalTraitInfo, Requires<RenderSpritesInfo>
{
[SequenceReference(null, true)]
[Desc("Sequence prefix to play when this actor is killed by a warhead.")]
[SequenceReference(null, true)] public readonly string DeathSequence = "die";
public readonly string DeathSequence = "die";
[PaletteReference("DeathPaletteIsPlayerPalette")]
[Desc("The palette used for `DeathSequence`.")]
[PaletteReference("DeathPaletteIsPlayerPalette")] public readonly string DeathSequencePalette = "player";
public readonly string DeathSequencePalette = "player";
[Desc("Custom death animation palette is a player palette BaseName")]
public readonly bool DeathPaletteIsPlayerPalette = true;
@@ -32,11 +34,13 @@ namespace OpenRA.Mods.Common.Traits.Render
[Desc("Should DeathType-specific sequences be used (sequence name = DeathSequence + DeathType).")]
public readonly bool UseDeathTypeSuffix = true; // TODO: check the complete sequence with lint rules
[SequenceReference]
[Desc("Sequence to play when this actor is crushed.")]
[SequenceReference] public readonly string CrushedSequence = null;
public readonly string CrushedSequence = null;
[PaletteReference("CrushedPaletteIsPlayerPalette")]
[Desc("The palette used for `CrushedSequence`.")]
[PaletteReference("CrushedPaletteIsPlayerPalette")] public readonly string CrushedSequencePalette = "effect";
public readonly string CrushedSequencePalette = "effect";
[Desc("Custom crushed animation palette is a player palette BaseName")]
public readonly bool CrushedPaletteIsPlayerPalette = false;
@@ -45,8 +49,9 @@ namespace OpenRA.Mods.Common.Traits.Render
"Is only used if UseDeathTypeSuffix is `True`.")]
public readonly Dictionary<string, string[]> DeathTypes = new Dictionary<string, string[]>();
[SequenceReference]
[Desc("Sequence to use when the actor is killed by some non-standard means (e.g. suicide).")]
[SequenceReference] public readonly string FallbackSequence = null;
public readonly string FallbackSequence = null;
public override object Create(ActorInitializer init) { return new WithDeathAnimation(init.Self, this); }
}