Fix and enable SA1133, SA1134 style rules.

This commit is contained in:
Paul Chote
2019-05-23 18:43:21 +00:00
committed by abcdefg30
parent fbf9461890
commit 78a70be0d4
214 changed files with 1012 additions and 432 deletions

View File

@@ -19,8 +19,9 @@ namespace OpenRA.Mods.Common.Traits.Sound
[Desc("Minimum duration (in seconds) between sound events.")]
public readonly int Interval = 5;
[VoiceReference]
[Desc("Voice to use when killing something.")]
[VoiceReference] public readonly string Voice = "Kill";
public readonly string Voice = "Kill";
public object Create(ActorInitializer init) { return new AnnounceOnKill(init.Self, this); }
}

View File

@@ -17,8 +17,9 @@ namespace OpenRA.Mods.Common.Traits.Sound
[Desc("Sounds to play when killed.")]
public class DeathSoundsInfo : ConditionalTraitInfo
{
[VoiceReference]
[Desc("Death notification voice.")]
[VoiceReference] public readonly string Voice = "Die";
public readonly string Voice = "Die";
[Desc("Multiply volume with this factor.")]
public readonly float VolumeMultiplier = 1f;

View File

@@ -16,9 +16,10 @@ namespace OpenRA.Mods.Common.Traits.Sound
[Desc("Plays a voice clip when the trait is enabled.")]
public class VoiceAnnouncementInfo : ConditionalTraitInfo
{
[VoiceReference]
[FieldLoader.Require]
[Desc("Voice to play.")]
[VoiceReference] public readonly string Voice = null;
public readonly string Voice = null;
[Desc("Player stances who can hear this voice.")]
public readonly Stance ValidStances = Stance.Ally | Stance.Neutral | Stance.Enemy;