Fix and enable SA1133, SA1134 style rules.

This commit is contained in:
Paul Chote
2019-05-23 18:43:21 +00:00
committed by abcdefg30
parent fbf9461890
commit 78a70be0d4
214 changed files with 1012 additions and 432 deletions

View File

@@ -19,11 +19,13 @@ namespace OpenRA.Mods.D2k.Traits.Render
[Desc("Rendered together with the \"make\" animation.")]
public class WithCrumbleOverlayInfo : ConditionalTraitInfo, Requires<RenderSpritesInfo>
{
[SequenceReference]
[Desc("Sequence name to use")]
[SequenceReference] public readonly string Sequence = "crumble-overlay";
public readonly string Sequence = "crumble-overlay";
[PaletteReference("IsPlayerPalette")]
[Desc("Custom palette name")]
[PaletteReference("IsPlayerPalette")] public readonly string Palette = null;
public readonly string Palette = null;
[Desc("Custom palette is a player palette BaseName")]
public readonly bool IsPlayerPalette = false;

View File

@@ -19,14 +19,16 @@ namespace OpenRA.Mods.D2k.Traits.Render
[Desc("Rendered when ProductionAirdrop is in progress.")]
public class WithDeliveryOverlayInfo : PausableConditionalTraitInfo, Requires<RenderSpritesInfo>, Requires<BodyOrientationInfo>
{
[SequenceReference]
[Desc("Sequence name to use")]
[SequenceReference] public readonly string Sequence = "active";
public readonly string Sequence = "active";
[Desc("Position relative to body")]
public readonly WVec Offset = WVec.Zero;
[PaletteReference("IsPlayerPalette")]
[Desc("Custom palette name")]
[PaletteReference("IsPlayerPalette")] public readonly string Palette = null;
public readonly string Palette = null;
[Desc("Custom palette is a player palette BaseName")]
public readonly bool IsPlayerPalette = false;

View File

@@ -18,11 +18,13 @@ namespace OpenRA.Mods.D2k.Traits
{
class D2kFogPaletteInfo : ITraitInfo
{
[FieldLoader.Require, PaletteDefinition]
[PaletteDefinition]
[FieldLoader.Require]
[Desc("Internal palette name")]
public readonly string Name = null;
[FieldLoader.Require, PaletteReference]
[PaletteReference]
[FieldLoader.Require]
[Desc("The name of the shroud palette to base off.")]
public readonly string BasePalette = null;

View File

@@ -25,7 +25,8 @@ namespace OpenRA.Mods.D2k.Traits
public class D2kResourceLayer : ResourceLayer
{
[Flags] public enum ClearSides : byte
[Flags]
public enum ClearSides : byte
{
None = 0x0,
Left = 0x1,

View File

@@ -20,11 +20,13 @@ namespace OpenRA.Mods.D2k.Traits
[Desc("Create a palette by applying a scale and offset to the colors in another palette.")]
class PaletteFromScaledPaletteInfo : ITraitInfo
{
[FieldLoader.Require, PaletteDefinition]
[PaletteDefinition]
[FieldLoader.Require]
[Desc("Internal palette name")]
public readonly string Name = null;
[FieldLoader.Require, PaletteReference]
[PaletteReference]
[FieldLoader.Require]
[Desc("The name of the palette to base off.")]
public readonly string BasePalette = null;