epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename *_RIGHT to *_WIDTH and *_BOTTOM to *_HEIGHT in integer expressions for widgets

Browse Source 
The terms "width" and "height" are clearer and they match what the values actually represent (window or parent width/height). The YAML changes are generated with the update rule.
This commit is contained in:
Ivaylo Draganov
2024-10-04 11:04:46 +03:00
committed by Gustas
parent bb17cfa179
commit 79ae71a517
125 changed files with 3503 additions and 3457 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OpenRA.Mods.Common/Widgets/Logic/ServerListLogic.cs
View File

@@ -243,7 +243,7 @@ namespace OpenRA.Mods.Common.Widgets.Logic
{
// HACK: MULTIPLAYER_FILTER_PANEL doesn't follow our normal procedure for dropdown creation
// but we still need to be able to set the dropdown width based on the parent
// The yaml should use PARENT_RIGHT instead of DROPDOWN_WIDTH
// The yaml should use PARENT_WIDTH instead of DROPDOWN_WIDTH
var filtersPanel = Ui.LoadWidget("MULTIPLAYER_FILTER_PANEL", filtersButton, new WidgetArgs());
filtersButton.Children.Remove(filtersPanel);

8
OpenRA.Mods.Common/Widgets/Logic/Settings/DisplaySettingsLogic.cs
View File

@@ -517,10 +517,10 @@ namespace OpenRA.Mods.Common.Widgets.Logic
var substitutions = new Dictionary<string, int>
{
{ "WINDOW_RIGHT", Game.Renderer.Resolution.Width },
{ "WINDOW_BOTTOM", Game.Renderer.Resolution.Height },
{ "PARENT_RIGHT", parentBounds.Width },
{ "PARENT_BOTTOM", parentBounds.Height }
{ "WINDOW_WIDTH", Game.Renderer.Resolution.Width },
{ "WINDOW_HEIGHT", Game.Renderer.Resolution.Height },
{ "PARENT_WIDTH", parentBounds.Width },
{ "PARENT_HEIGHT", parentBounds.Height }
};
var readOnlySubstitutions = new ReadOnlyDictionary<string, int>(substitutions);