epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

.Any(), .Count() -> .Count or .Length

Browse Source
This commit is contained in:
Eduardo Cáceres
2022-05-02 13:05:22 +02:00
committed by atlimit8
parent 6eb4fe8980
commit 79f321cb44
138 changed files with 233 additions and 258 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
OpenRA.Mods.Common/Lint/CheckUnknownTraitFields.cs
View File

@@ -11,7 +11,6 @@
using System;
using System.Collections.Generic;
using System.Linq;
using OpenRA.FileSystem;
using OpenRA.Server;
@@ -53,7 +52,7 @@ namespace OpenRA.Mods.Common.Lint
// Removals can never define children or values
if (t.Key.StartsWith("-", StringComparison.Ordinal))
{
if (t.Value.Nodes.Any())
if (t.Value.Nodes.Count > 0)
emitError($"{t.Location} {t.Key} defines child nodes, which are not valid for removals.");
if (!string.IsNullOrEmpty(t.Value.Value))
@@ -65,7 +64,7 @@ namespace OpenRA.Mods.Common.Lint
var traitName = NormalizeName(t.Key);
// Inherits can never define children
if (traitName == "Inherits" && t.Value.Nodes.Any())
if (traitName == "Inherits" && t.Value.Nodes.Count > 0)
{
emitError($"{t.Location} defines child nodes, which are not valid for Inherits.");
continue;
@@ -91,7 +90,7 @@ namespace OpenRA.Mods.Common.Lint
foreach (var f in mapFiles)
CheckActors(MiniYaml.FromStream(fileSystem.Open(f), f), emitError, modData);
if (ruleDefinitions.Nodes.Any())
if (ruleDefinitions.Nodes.Count > 0)
CheckActors(ruleDefinitions.Nodes, emitError, modData);
}
}