diff --git a/OpenRA.Game/GameRules/RulesetCache.cs b/OpenRA.Game/GameRules/RulesetCache.cs index a9a512e502..b7cc7bd044 100755 --- a/OpenRA.Game/GameRules/RulesetCache.cs +++ b/OpenRA.Game/GameRules/RulesetCache.cs @@ -43,12 +43,11 @@ namespace OpenRA this.modData = modData; } - public Ruleset LoadDefaultRules() - { - return LoadMapRules(null); - } - - public Ruleset LoadMapRules(Map map) + /// + /// Cache and return the Ruleset for a given map. + /// If a map isn't specified then return the default mod Ruleset. + /// + public Ruleset Load(Map map = null) { var m = modData.Manifest; diff --git a/OpenRA.Game/Map/Map.cs b/OpenRA.Game/Map/Map.cs index dd7456ec20..499cc3c85e 100644 --- a/OpenRA.Game/Map/Map.cs +++ b/OpenRA.Game/Map/Map.cs @@ -387,7 +387,7 @@ namespace OpenRA { try { - return Game.ModData.RulesetCache.LoadMapRules(this); + return Game.ModData.RulesetCache.Load(this); } catch (Exception e) { diff --git a/OpenRA.Game/ModData.cs b/OpenRA.Game/ModData.cs index d0a2b037d6..4042318503 100644 --- a/OpenRA.Game/ModData.cs +++ b/OpenRA.Game/ModData.cs @@ -79,7 +79,7 @@ namespace OpenRA foreach (var dir in Manifest.Folders) GlobalFileSystem.Mount(dir); - defaultRules = Exts.Lazy(() => RulesetCache.LoadDefaultRules()); + defaultRules = Exts.Lazy(() => RulesetCache.Load()); initialThreadId = System.Threading.Thread.CurrentThread.ManagedThreadId; } diff --git a/OpenRA.Mods.Common/Lint/CheckMapRules.cs b/OpenRA.Mods.Common/Lint/CheckMapRules.cs index b75e37ae03..563992dddf 100644 --- a/OpenRA.Mods.Common/Lint/CheckMapRules.cs +++ b/OpenRA.Mods.Common/Lint/CheckMapRules.cs @@ -19,7 +19,7 @@ namespace OpenRA.Mods.Common.Lint { try { - Game.ModData.RulesetCache.LoadMapRules(map); + Game.ModData.RulesetCache.Load(map); } catch (Exception e) { diff --git a/OpenRA.Mods.Common/UtilityCommands/ActorStatsExport.cs b/OpenRA.Mods.Common/UtilityCommands/ActorStatsExport.cs index 883d103ed3..9ae4a9510d 100644 --- a/OpenRA.Mods.Common/UtilityCommands/ActorStatsExport.cs +++ b/OpenRA.Mods.Common/UtilityCommands/ActorStatsExport.cs @@ -22,7 +22,7 @@ namespace OpenRA.Mods.Common.UtilityCommands { public static DataTable GenerateTable() { - var rules = Game.ModData.RulesetCache.LoadDefaultRules(); + var rules = Game.ModData.RulesetCache.Load(); var table = new DataTable(); table.Columns.Add("Name", typeof(string)); diff --git a/OpenRA.Mods.Common/UtilityCommands/ExtractLanguageStringsCommand.cs b/OpenRA.Mods.Common/UtilityCommands/ExtractLanguageStringsCommand.cs index 2f24eafd47..551bc0a0c8 100644 --- a/OpenRA.Mods.Common/UtilityCommands/ExtractLanguageStringsCommand.cs +++ b/OpenRA.Mods.Common/UtilityCommands/ExtractLanguageStringsCommand.cs @@ -25,7 +25,7 @@ namespace OpenRA.Mods.Common.UtilityCommands { // HACK: The engine code assumes that Game.modData is set. Game.ModData = modData; - Game.ModData.RulesetCache.LoadDefaultRules(); + Game.ModData.RulesetCache.Load(); var types = Game.ModData.ObjectCreator.GetTypes(); var translatableFields = types.SelectMany(t => t.GetFields()) diff --git a/OpenRA.Mods.Common/UtilityCommands/ImportLegacyMapCommand.cs b/OpenRA.Mods.Common/UtilityCommands/ImportLegacyMapCommand.cs index 10b33452cf..31529006c5 100644 --- a/OpenRA.Mods.Common/UtilityCommands/ImportLegacyMapCommand.cs +++ b/OpenRA.Mods.Common/UtilityCommands/ImportLegacyMapCommand.cs @@ -23,7 +23,7 @@ namespace OpenRA.Mods.Common.UtilityCommands // HACK: The engine code assumes that Game.modData is set. Game.ModData = modData; - var rules = Game.ModData.RulesetCache.LoadDefaultRules(); + var rules = Game.ModData.RulesetCache.Load(); var map = LegacyMapImporter.Import(args[1], modData.Manifest.Mod.Id, rules, Console.WriteLine); var fileName = Path.GetFileNameWithoutExtension(args[1]); diff --git a/OpenRA.Mods.Common/UtilityCommands/RemapShpCommand.cs b/OpenRA.Mods.Common/UtilityCommands/RemapShpCommand.cs index 2f44c4db18..ebde509782 100644 --- a/OpenRA.Mods.Common/UtilityCommands/RemapShpCommand.cs +++ b/OpenRA.Mods.Common/UtilityCommands/RemapShpCommand.cs @@ -39,14 +39,14 @@ namespace OpenRA.Mods.Common.UtilityCommands Game.ModData = new ModData(srcMod); GlobalFileSystem.LoadFromManifest(Game.ModData.Manifest); - var srcRules = Game.ModData.RulesetCache.LoadDefaultRules(); + var srcRules = Game.ModData.RulesetCache.Load(); var srcPaletteInfo = srcRules.Actors["player"].Traits.Get(); var srcRemapIndex = srcPaletteInfo.RemapIndex; var destMod = args[2].Split(':')[0]; Game.ModData = new ModData(destMod); GlobalFileSystem.LoadFromManifest(Game.ModData.Manifest); - var destRules = Game.ModData.RulesetCache.LoadDefaultRules(); + var destRules = Game.ModData.RulesetCache.Load(); var destPaletteInfo = destRules.Actors["player"].Traits.Get(); var destRemapIndex = destPaletteInfo.RemapIndex; var shadowIndex = new int[] { }; diff --git a/OpenRA.Mods.D2k/UtilityCommands/ImportD2kMapCommand.cs b/OpenRA.Mods.D2k/UtilityCommands/ImportD2kMapCommand.cs index fb3b752177..840be72081 100644 --- a/OpenRA.Mods.D2k/UtilityCommands/ImportD2kMapCommand.cs +++ b/OpenRA.Mods.D2k/UtilityCommands/ImportD2kMapCommand.cs @@ -23,7 +23,7 @@ namespace OpenRA.Mods.D2k.UtilityCommands // HACK: The engine code assumes that Game.modData is set. Game.ModData = modData; - var rules = Game.ModData.RulesetCache.LoadDefaultRules(); + var rules = Game.ModData.RulesetCache.Load(); var map = D2kMapImporter.Import(args[1], modData.Manifest.Mod.Id, args[2], rules);