epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove public mutable state from Connection.

Browse Source
This commit is contained in:
Paul Chote
2021-05-05 22:47:36 +01:00
committed by reaperrr
parent dacacdf130
commit 7e79e69eae
2 changed files with 40 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
OpenRA.Game/Server/Connection.cs
View File

@@ -19,21 +19,29 @@ namespace OpenRA.Server
public class Connection
{
public const int MaxOrderLength = 131072;
public Socket Socket;
public List<byte> Data = new List<byte>();
public ReceiveState State = ReceiveState.Header;
public int ExpectLength = 8;
public int Frame = 0;
public int MostRecentFrame = 0;
public bool Validated;
public readonly Socket Socket;
public readonly List<byte> Data = new List<byte>();
public readonly int PlayerIndex;
public readonly string AuthToken;
public long TimeSinceLastResponse => Game.RunTime - lastReceivedTime;
public bool TimeoutMessageShown = false;
public int MostRecentFrame { get; private set; }
public bool TimeoutMessageShown;
public bool Validated;
ReceiveState state = ReceiveState.Header;
int expectLength = 8;
int frame = 0;
long lastReceivedTime = 0;
/* client data */
public int PlayerIndex;
public string AuthToken;
public Connection(Socket socket, int playerIndex, string authToken)
{
Socket = socket;
PlayerIndex = playerIndex;
AuthToken = authToken;
}
public byte[] PopBytes(int n)
{
@@ -85,21 +93,22 @@ namespace OpenRA.Server
public void ReadData(Server server)
{
if (ReadDataInner(server))
while (Data.Count >= ExpectLength)
{
var bytes = PopBytes(ExpectLength);
switch (State)
while (Data.Count >= expectLength)
{
var bytes = PopBytes(expectLength);
switch (state)
{
case ReceiveState.Header:
{
ExpectLength = BitConverter.ToInt32(bytes, 0) - 4;
Frame = BitConverter.ToInt32(bytes, 4);
State = ReceiveState.Data;
expectLength = BitConverter.ToInt32(bytes, 0) - 4;
frame = BitConverter.ToInt32(bytes, 4);
state = ReceiveState.Data;
if (ExpectLength < 0 || ExpectLength > MaxOrderLength)
if (expectLength < 0 || expectLength > MaxOrderLength)
{
server.DropClient(this);
Log.Write("server", "Dropping client {0} for excessive order length = {1}", PlayerIndex, ExpectLength);
Log.Write("server", "Dropping client {0} for excessive order length = {1}", PlayerIndex, expectLength);
return;
}
@@ -108,12 +117,12 @@ namespace OpenRA.Server
case ReceiveState.Data:
{
if (MostRecentFrame < Frame)
MostRecentFrame = Frame;
if (MostRecentFrame < frame)
MostRecentFrame = frame;
server.DispatchOrders(this, Frame, bytes);
ExpectLength = 8;
State = ReceiveState.Header;
server.DispatchOrders(this, frame, bytes);
expectLength = 8;
state = ReceiveState.Header;
break;
}
@@ -121,6 +130,7 @@ namespace OpenRA.Server
}
}
}
}
public enum ReceiveState { Header, Data }
}

13
OpenRA.Game/Server/Server.cs
View File

@@ -374,19 +374,16 @@ namespace OpenRA.Server
return;
}
var newConn = new Connection { Socket = newSocket };
try
{
newConn.Socket.Blocking = false;
newConn.Socket.NoDelay = true;
// Validate player identity by asking them to sign a random blob of data
// which we can then verify against the player public key database
var token = Convert.ToBase64String(OpenRA.Exts.MakeArray(256, _ => (byte)Random.Next()));
// Assign the player number.
newConn.PlayerIndex = ChooseFreePlayerIndex();
newConn.AuthToken = token;
var newConn = new Connection(newSocket, ChooseFreePlayerIndex(), token);
try
{
newConn.Socket.Blocking = false;
newConn.Socket.NoDelay = true;
// Send handshake and client index.
var ms = new MemoryStream(8);