epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix IDE0029

Browse Source
This commit is contained in:
RoosterDragon
2023-02-19 10:24:14 +00:00
committed by Pavel Penev
parent 67ba3e55de
commit 8223161959
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.editorconfig
View File

@@ -153,6 +153,9 @@ dotnet_diagnostic.IDE0020.severity = warning
# Collection initialization can be simplified # Collection initialization can be simplified
dotnet_diagnostic.IDE0028.severity = warning dotnet_diagnostic.IDE0028.severity = warning
# Use coalesce expression (non-nullable types).
dotnet_diagnostic.IDE0029.severity = warning
# Simplify 'default' expression # Simplify 'default' expression
dotnet_diagnostic.IDE0034.severity = warning dotnet_diagnostic.IDE0034.severity = warning

2
OpenRA.Mods.Common/Terrain/DefaultTileCache.cs
View File

@@ -94,7 +94,7 @@ namespace OpenRA.Mods.Common.Terrain
} }
var frameCount = terrainInfo.EnableDepth && depthFrames == null ? allFrames.Length / 2 : allFrames.Length; var frameCount = terrainInfo.EnableDepth && depthFrames == null ? allFrames.Length / 2 : allFrames.Length;
var indices = templateInfo.Frames != null ? templateInfo.Frames : Exts.MakeArray(t.Value.TilesCount, j => j); var indices = templateInfo.Frames ?? Exts.MakeArray(t.Value.TilesCount, j => j);
var start = indices.Min(); var start = indices.Min();
var end = indices.Max(); var end = indices.Max();

2
OpenRA.Mods.Common/Traits/Player/ProductionQueue.cs
View File

@@ -591,7 +591,7 @@ namespace OpenRA.Mods.Common.Traits
{ {
var traits = productionTraits.Where(p => !p.IsTraitDisabled && p.Info.Produces.Contains(Info.Type)); var traits = productionTraits.Where(p => !p.IsTraitDisabled && p.Info.Produces.Contains(Info.Type));
var unpaused = traits.FirstOrDefault(a => !a.IsTraitPaused); var unpaused = traits.FirstOrDefault(a => !a.IsTraitPaused);
return new TraitPair<Production>(self, unpaused != null ? unpaused : traits.FirstOrDefault()); return new TraitPair<Production>(self, unpaused ?? traits.FirstOrDefault());
} }
// Builds a unit from the actor that holds this queue (1 queue per building) // Builds a unit from the actor that holds this queue (1 queue per building)