Touch up CheckPlayers.cs

This commit is contained in:
penev92
2015-07-12 00:53:29 +03:00
parent 0f0497b74d
commit 830b7eee70

View File

@@ -21,7 +21,7 @@ namespace OpenRA.Mods.Common.Lint
{ {
var players = new MapPlayers(map.PlayerDefinitions).Players; var players = new MapPlayers(map.PlayerDefinitions).Players;
var playerNames = players.Values.Select(p => p.Name); var playerNames = players.Values.Select(p => p.Name).ToHashSet();
foreach (var player in players.Values) foreach (var player in players.Values)
{ {
foreach (var ally in player.Allies) foreach (var ally in player.Allies)
@@ -38,14 +38,14 @@ namespace OpenRA.Mods.Common.Lint
var worldActor = map.Rules.Actors["world"]; var worldActor = map.Rules.Actors["world"];
var races = worldActor.Traits.WithInterface<FactionInfo>().Select(f => f.InternalName); var races = worldActor.Traits.WithInterface<FactionInfo>().Select(f => f.InternalName).ToHashSet();
foreach (var player in players.Values) foreach (var player in players.Values)
if (!string.IsNullOrWhiteSpace(player.Race) && !races.Contains(player.Race)) if (!string.IsNullOrWhiteSpace(player.Race) && !races.Contains(player.Race))
emitError("Invalid race {0} chosen for player {1}.".F(player.Race, player.Name)); emitError("Invalid race {0} chosen for player {1}.".F(player.Race, player.Name));
if (worldActor.Traits.Contains<MPStartLocationsInfo>()) if (worldActor.Traits.Contains<MPStartLocationsInfo>())
{ {
var multiPlayers = players.Where(p => p.Value.Playable).Count(); var multiPlayers = players.Count(p => p.Value.Playable);
var spawns = map.ActorDefinitions.Where(a => a.Value.Value == "mpspawn"); var spawns = map.ActorDefinitions.Where(a => a.Value.Value == "mpspawn");
var spawnCount = spawns.Count(); var spawnCount = spawns.Count();