epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bot-controlled aircraft stalling above cloaked targets.

Browse Source
This commit is contained in:
Paul Chote
2021-01-10 15:35:03 +00:00
committed by reaperrr
parent 58313520f0
commit 84ced8704d
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
OpenRA.Mods.Common/Activities/Air/FlyAttack.cs
View File

@@ -142,6 +142,13 @@ namespace OpenRA.Mods.Common.Activities
// We don't know where the target actually is, so move to where we last saw it // We don't know where the target actually is, so move to where we last saw it
if (useLastVisibleTarget) if (useLastVisibleTarget)
{ {
// HACK: Bot players ignore the standard visibility checks in target.Recalculate,
// which means that targetIsHiddenActor is always false, allowing lastVisibleMaximumRange
// to be assigned zero range by attackAircraft.GetMaximumRangeVersusTarget for e.g. cloaked actors.
// Catch and cancel this edge case to avoid the aircraft stopping mid-air!
if (self.Owner.IsBot && lastVisibleMaximumRange == WDist.Zero)
return true;
// We've reached the assumed position but it is not there - give up // We've reached the assumed position but it is not there - give up
if (checkTarget.IsInRange(pos, lastVisibleMaximumRange)) if (checkTarget.IsInRange(pos, lastVisibleMaximumRange))
return true; return true;