Merge pull request #8321 from penev92/bleed_lintUpgrades

Add a lint check for actor upgrades

OpenRA.Mods.Common/Traits/Crates/GrantUpgradeCrateAction.cs

@@ -9,12 +9,14 @@
 #endregion
 
 using System.Linq;
+using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Traits
 {
 	[Desc("Grants an upgrade to the collector.")]
 	public class GrantUpgradeCrateActionInfo : CrateActionInfo
 	{
+		[UpgradeGrantedReference]
 		[Desc("The upgrades to apply.")]
 		public readonly string[] Upgrades = { };
 

OpenRA.Mods.Common/Traits/GlobalUpgradable.cs

@@ -13,9 +13,14 @@ using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Traits
 {
+	[Desc("Grants upgrades to the actor this is attached to when prerequisites are available.")]
 	public class GlobalUpgradableInfo : ITraitInfo, Requires<UpgradeManagerInfo>
 	{
+		[UpgradeGrantedReference]
+		[Desc("List of upgrades to apply.")]
 		public readonly string[] Upgrades = { };
+
+		[Desc("List of required prerequisites.")]
 		public readonly string[] Prerequisites = { };
 
 		public object Create(ActorInitializer init) { return new GlobalUpgradable(init.Self, this); }

OpenRA.Mods.Common/Traits/SupportPowers/GrantUpgradePower.cs

@@ -19,6 +19,7 @@ namespace OpenRA.Mods.Common.Traits
 {
 	class GrantUpgradePowerInfo : SupportPowerInfo
 	{
+		[UpgradeGrantedReference]
 		[Desc("The upgrades to apply.")]
 		public readonly string[] Upgrades = { };
 

OpenRA.Mods.Common/Traits/Upgrades/DeployToUpgrade.cs

@@ -18,6 +18,7 @@ namespace OpenRA.Mods.Common.Traits
 {
 	public class DeployToUpgradeInfo : ITraitInfo, Requires<UpgradeManagerInfo>
 	{
+		[UpgradeGrantedReference]
 		[Desc("The upgrades to grant when deploying and revoke when undeploying.")]
 		public readonly string[] Upgrades = { };
 

OpenRA.Mods.Common/Traits/Upgrades/UpgradableTrait.cs

@@ -7,6 +7,7 @@
  * see COPYING.
  */
 #endregion
+
 using System.Collections.Generic;
 using System.Linq;
 using OpenRA.Traits;
@@ -16,6 +17,7 @@ namespace OpenRA.Mods.Common.Traits
 	/// <summary>Use as base class for *Info to subclass of UpgradableTrait. (See UpgradableTrait.)</summary>
 	public abstract class UpgradableTraitInfo
 	{
+		[UpgradeUsedReference]
 		[Desc("The upgrade types which can enable or disable this trait.")]
 		public readonly string[] UpgradeTypes = { };
 

OpenRA.Mods.Common/Traits/Upgrades/UpgradeActorsNear.cs

@@ -18,6 +18,7 @@ namespace OpenRA.Mods.Common.Traits
 	[Desc("Applies an upgrade to actors within a specified range.")]
 	public class UpgradeActorsNearInfo : ITraitInfo
 	{
+		[UpgradeGrantedReference]
 		[Desc("The upgrades to grant.")]
 		public readonly string[] Upgrades = { };