From 8c9cc9318527a006379d054701a0f75d61669a47 Mon Sep 17 00:00:00 2001 From: abcdefg30 Date: Thu, 11 May 2023 17:57:34 +0200 Subject: [PATCH] Fix the ExplicitSequenceFilenames rule breaking when updating single maps --- .../Rules/20221203/ExplicitSequenceFilenames.cs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs index b3ed5806e9..df3ebed861 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs @@ -132,8 +132,14 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules var implicitInheritedSequences = new List(); foreach (var resolvedSequenceNode in resolvedImageNode.Value.Nodes) { - if (resolvedSequenceNode.Key != "Defaults" && string.IsNullOrEmpty(resolvedSequenceNode.Value.Value) && - imageNode.LastChildMatching(resolvedSequenceNode.Key) == null) + if (resolvedSequenceNode.Key == "Defaults") + continue; + + // Ignore nodes that are not implicitly named or already processed + if (!string.IsNullOrEmpty(resolvedSequenceNode.Value.Value) || resolvedSequenceNode.LastChildMatching("Filename") != null) + continue; + + if (imageNode.LastChildMatching(resolvedSequenceNode.Key) == null) { imageNode.AddNode(resolvedSequenceNode.Key, ""); implicitInheritedSequences.Add(resolvedSequenceNode.Key);