epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace arrays with sets.

Browse Source 
In places where arrays were being treated as a set, just create a set directly. This reveals the intention of such collections better, and also improves performance by allowing set based methods to be used.
This commit is contained in:
RoosterDragon
2015-09-03 20:09:16 +01:00
parent 4f4bab2cdf
commit 901e604cf3
19 changed files with 43 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
OpenRA.Mods.Common/AI/SupportPowerDecision.cs
View File

@@ -100,7 +100,7 @@ namespace OpenRA.Mods.Common.AI
public readonly Stance Against = Stance.Enemy;
[Desc("What types should the desired targets of this power be?")]
public readonly string[] Types = { "Air", "Ground", "Water" };
public readonly HashSet<string> Types = new HashSet<string> { "Air", "Ground", "Water" };
[Desc("How attractive are these types of targets?")]
public readonly int Attractiveness = 100;
@@ -129,7 +129,7 @@ namespace OpenRA.Mods.Common.AI
if (!targetable.Any(t => t.TargetableBy(a, firedBy.PlayerActor)))
return 0;
if (Types.Intersect(targetable.SelectMany(t => t.TargetTypes)).Any())
if (Types.Overlaps(targetable.SelectMany(t => t.TargetTypes)))
{
switch (TargetMetric)
{