From 90981e5bda79bdafd5685ef9d1c365e7a5b21d82 Mon Sep 17 00:00:00 2001 From: RoosterDragon Date: Fri, 27 Apr 2018 21:33:10 +0100 Subject: [PATCH] Avoid redundant property reads in Renderer.SetViewportParams --- OpenRA.Game/Renderer.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/OpenRA.Game/Renderer.cs b/OpenRA.Game/Renderer.cs index 330603a8b5..2d737157fb 100644 --- a/OpenRA.Game/Renderer.cs +++ b/OpenRA.Game/Renderer.cs @@ -41,9 +41,9 @@ namespace OpenRA float depthScale; float depthOffset; - Size? lastResolution; - int2? lastScroll; - float? lastZoom; + Size lastResolution = new Size(-1, -1); + int2 lastScroll = new int2(-1, -1); + float lastZoom = -1f; ITexture currentPaletteTexture; IBatchRenderer currentBatchRenderer; @@ -124,8 +124,8 @@ namespace OpenRA if (resolutionChanged) { lastResolution = Resolution; - RgbaSpriteRenderer.SetViewportParams(Resolution, 0f, 0f, 1f, int2.Zero); - SpriteRenderer.SetViewportParams(Resolution, 0f, 0f, 1f, int2.Zero); + RgbaSpriteRenderer.SetViewportParams(lastResolution, 0f, 0f, 1f, int2.Zero); + SpriteRenderer.SetViewportParams(lastResolution, 0f, 0f, 1f, int2.Zero); } // If zoom evaluates as different due to floating point weirdness that's OK, setting the parameters again is harmless. @@ -133,9 +133,9 @@ namespace OpenRA { lastScroll = scroll; lastZoom = zoom; - WorldRgbaSpriteRenderer.SetViewportParams(Resolution, depthScale, depthOffset, zoom, scroll); - WorldSpriteRenderer.SetViewportParams(Resolution, depthScale, depthOffset, zoom, scroll); - WorldModelRenderer.SetViewportParams(Resolution, zoom, scroll); + WorldRgbaSpriteRenderer.SetViewportParams(lastResolution, depthScale, depthOffset, zoom, scroll); + WorldSpriteRenderer.SetViewportParams(lastResolution, depthScale, depthOffset, zoom, scroll); + WorldModelRenderer.SetViewportParams(lastResolution, zoom, scroll); } }