Fix CA1851, assume_method_enumerates_parameters = true

2023-07-14 20:30:08 +01:00
parent 3275875ae5
commit 93a97d5d6f
37 changed files with 108 additions and 96 deletions
--- a/OpenRA.Mods.Common/Traits/Crates/GiveUnitCrateAction.cs
+++ b/OpenRA.Mods.Common/Traits/Crates/GiveUnitCrateAction.cs
@@ -111,11 +111,9 @@ namespace OpenRA.Mods.Common.Traits

 		CPos? ChooseEmptyCellNear(Actor a, string unit)
 		{
-			var possibleCells = GetSuitableCells(a.Location, unit);
-			if (!possibleCells.Any())
-				return null;
-
-			return possibleCells.Random(self.World.SharedRandom);
+			return GetSuitableCells(a.Location, unit)
+				.Cast<CPos?>()
+				.RandomOrDefault(self.World.SharedRandom);
 		}
 	}
 }