From 98563eb854974d210ba69e0dbd2a320bb354bdb5 Mon Sep 17 00:00:00 2001
From: Chris Forbes <chrisf@ijw.co.nz>
Date: Tue, 7 Oct 2014 18:24:00 +1300
Subject: [PATCH] PrimaryBuilding: Fix benign loop variable in closure hazard

This never outlived a single loop iteration.
---
 OpenRA.Mods.RA/PrimaryBuilding.cs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/OpenRA.Mods.RA/PrimaryBuilding.cs b/OpenRA.Mods.RA/PrimaryBuilding.cs
index 6cf53664a3..226f1ff6fe 100755
--- a/OpenRA.Mods.RA/PrimaryBuilding.cs
+++ b/OpenRA.Mods.RA/PrimaryBuilding.cs
@@ -67,13 +67,16 @@ namespace OpenRA.Mods.RA
 			// TODO: THIS IS SHIT
 			// Cancel existing primaries
 			foreach (var p in self.Info.Traits.Get<ProductionInfo>().Produces)
+			{
+				var productionType = p;		// benign closure hazard
 				foreach (var b in self.World
 					.ActorsWithTrait<PrimaryBuilding>()
 					.Where(a =>
 						a.Actor.Owner == self.Owner &&
 						a.Trait.IsPrimary &&
-						a.Actor.Info.Traits.Get<ProductionInfo>().Produces.Contains(p)))
+						a.Actor.Info.Traits.Get<ProductionInfo>().Produces.Contains(productionType)))
 					b.Trait.SetPrimaryProducer(b.Actor, false);
+			}
 
 			isPrimary = true;