Convert ResupplyAircraft into a CompositeActivity

This commit is contained in:
Oliver Brakmann
2016-12-08 21:48:12 +01:00
parent 9b0780e87c
commit 9993a235a7

View File

@@ -16,31 +16,21 @@ using OpenRA.Traits;
namespace OpenRA.Mods.Common.Activities
{
public class ResupplyAircraft : Activity
public class ResupplyAircraft : CompositeActivity
{
readonly Aircraft aircraft;
Activity inner;
public ResupplyAircraft(Actor self) { }
public ResupplyAircraft(Actor self)
{
aircraft = self.Trait<Aircraft>();
}
public override Activity Tick(Actor self)
{
if (IsCanceled)
return NextActivity;
if (inner == null)
protected override void OnFirstRun(Actor self)
{
var aircraft = self.Trait<Aircraft>();
var host = aircraft.GetActorBelow();
if (host == null)
return NextActivity;
return;
if (aircraft.IsPlane)
{
inner = ActivityUtils.SequenceActivities(
ChildActivity = ActivityUtils.SequenceActivities(
aircraft.GetResupplyActivities(host)
.Append(new AllowYieldingReservation(self))
.Append(new WaitFor(() => NextInQueue != null || aircraft.ReservedActor == null))
@@ -50,25 +40,16 @@ namespace OpenRA.Mods.Common.Activities
{
// Helicopters should take off from their helipad immediately after resupplying.
// HACK: Append NextInQueue to TakeOff to avoid moving to the Rallypoint (if NextInQueue is non-null).
inner = ActivityUtils.SequenceActivities(
ChildActivity = ActivityUtils.SequenceActivities(
aircraft.GetResupplyActivities(host)
.Append(new AllowYieldingReservation(self))
.Append(new TakeOff(self)).Append(NextInQueue).ToArray());
}
}
else
inner = ActivityUtils.RunActivity(self, inner);
// The inner == NextInQueue check is needed here because of the TakeOff issue mentioned in the comment above.
return inner == null || inner == NextInQueue ? NextActivity : this;
}
public override bool Cancel(Actor self)
public override Activity Tick(Actor self)
{
if (!IsCanceled && inner != null && !inner.Cancel(self))
return false;
return base.Cancel(self);
return NextActivity;
}
}
}