epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix RCS1236

Browse Source
This commit is contained in:
RoosterDragon
2023-08-11 19:47:48 +01:00
committed by Gustas
parent 498c6e3d8b
commit 9a3c39878d
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.editorconfig
View File

@@ -1136,5 +1136,9 @@ dotnet_diagnostic.RCS1233.severity = warning
# Optimize method call. # Optimize method call.
dotnet_diagnostic.RCS1235.severity = warning dotnet_diagnostic.RCS1235.severity = warning
# Use exception filter.
dotnet_diagnostic.RCS1236.severity = warning
# Use 'for' statement instead of 'while' statement. # Use 'for' statement instead of 'while' statement.
dotnet_diagnostic.RCS1239.severity = warning dotnet_diagnostic.RCS1239.severity = warning

4
OpenRA.Game/FileSystem/FileSystem.cs
View File

@@ -109,10 +109,8 @@ namespace OpenRA.FileSystem
Mount(package, explicitName); Mount(package, explicitName);
} }
catch catch when (optional)
{ {
if (!optional)
throw;
} }
} }

7
OpenRA.Game/Server/Server.cs
View File

@@ -248,12 +248,9 @@ namespace OpenRA.Server
{ {
listener.Server.SetSocketOption(SocketOptionLevel.IPv6, SocketOptionName.IPv6Only, 1); listener.Server.SetSocketOption(SocketOptionLevel.IPv6, SocketOptionName.IPv6Only, 1);
} }
catch (Exception ex) catch (Exception ex) when (ex is SocketException || ex is ArgumentException)
{ {
if (ex is SocketException || ex is ArgumentException) Log.Write("server", $"Failed to set socket option on {endpoint}: {ex.Message}");
Log.Write("server", $"Failed to set socket option on {endpoint}: {ex.Message}");
else
throw;
} }
listener.Start(); listener.Start();