epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't throw an exception when a field is missing

Browse Source
This commit is contained in:
abcdefg30
2019-10-08 17:28:30 +02:00
committed by teinarss
parent f037436536
commit 9a5eaa7cb7
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
OpenRA.Game/ObjectCreator.cs
View File

@@ -74,8 +74,8 @@ namespace OpenRA
return assemblies.Select(a => a.First).FirstOrDefault(a => a.FullName == e.Name);
}
public static Action<string> MissingTypeAction =
s => { throw new InvalidOperationException("Cannot locate type: {0}".F(s)); };
// Only used by the linter to prevent exceptions from being thrown during a lint run
public static Action<string> MissingTypeAction = null;
public T CreateObject<T>(string className)
{
@@ -87,7 +87,12 @@ namespace OpenRA
var type = typeCache[className];
if (type == null)
{
MissingTypeAction(className);
// HACK: The linter does not want to crash but only print an error instead
if (MissingTypeAction != null)
MissingTypeAction(className);
else
throw new InvalidOperationException("Cannot locate type: {0}".F(className));
return default(T);
}