From 9d7ac73410d7a97c5df288e8c5a1de19ede5a844 Mon Sep 17 00:00:00 2001 From: Chris Forbes Date: Mon, 2 May 2011 10:47:25 +1200 Subject: [PATCH] pull BuildingInfluence trait lookup out of the inner loop of building placement --- OpenRA.Mods.RA/Buildings/Building.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/OpenRA.Mods.RA/Buildings/Building.cs b/OpenRA.Mods.RA/Buildings/Building.cs index ea0645d84f..015330b3af 100755 --- a/OpenRA.Mods.RA/Buildings/Building.cs +++ b/OpenRA.Mods.RA/Buildings/Building.cs @@ -45,11 +45,13 @@ namespace OpenRA.Mods.RA.Buildings var nearnessCandidates = new List(); + var bi = world.WorldActor.Trait(); + for( int y = scanStart.Y ; y < scanEnd.Y ; y++ ) { for( int x = scanStart.X ; x < scanEnd.X ; x++ ) { - var at = world.WorldActor.Trait().GetBuildingAt( new int2( x, y ) ); + var at = bi.GetBuildingAt( new int2( x, y ) ); if( at != null && at.Owner.Stances[ p ] == Stance.Ally && at.Info.Traits.Get().BaseNormal ) nearnessCandidates.Add( new int2( x, y ) ); }