epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Unhardcode the leeway range of AttackFollow

Browse Source
This commit is contained in:
abcdefg30
2020-08-23 15:13:27 +02:00
committed by reaperrr
parent c0d31688c4
commit 9f093da61e
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs
View File

@@ -27,6 +27,9 @@ namespace OpenRA.Mods.Common.Traits
[Desc("Keep firing on targets even after attack order is cancelled")] [Desc("Keep firing on targets even after attack order is cancelled")]
public readonly bool PersistentTargeting = true; public readonly bool PersistentTargeting = true;
[Desc("Range to stay away from min and max ranges to give some leeway if the target starts moving.")]
public readonly WDist RangeMargin = WDist.FromCells(1);
public override object Create(ActorInitializer init) { return new AttackFollow(init.Self, this); } public override object Create(ActorInitializer init) { return new AttackFollow(init.Self, this); }
} }
@@ -282,12 +285,12 @@ namespace OpenRA.Mods.Common.Traits
lastVisibleOwner = target.Actor.Owner; lastVisibleOwner = target.Actor.Owner;
lastVisibleTargetTypes = target.Actor.GetEnabledTargetTypes(); lastVisibleTargetTypes = target.Actor.GetEnabledTargetTypes();
// Try and sit at least one cell away from the min or max ranges to give some leeway if the target starts moving. var leeway = attack.Info.RangeMargin.Length;
if (move != null && target.Actor.Info.HasTraitInfo<IMoveInfo>()) if (leeway != 0 && move != null && target.Actor.Info.HasTraitInfo<IMoveInfo>())
{ {
var preferMinRange = Math.Min(lastVisibleMinimumRange.Length + 1024, lastVisibleMaximumRange.Length); var preferMinRange = Math.Min(lastVisibleMinimumRange.Length + leeway, lastVisibleMaximumRange.Length);
var preferMaxRange = Math.Max(lastVisibleMaximumRange.Length - 1024, lastVisibleMinimumRange.Length); var preferMaxRange = Math.Max(lastVisibleMaximumRange.Length - leeway, lastVisibleMinimumRange.Length);
lastVisibleMaximumRange = new WDist((lastVisibleMaximumRange.Length - 1024).Clamp(preferMinRange, preferMaxRange)); lastVisibleMaximumRange = new WDist((lastVisibleMaximumRange.Length - leeway).Clamp(preferMinRange, preferMaxRange));
} }
} }