epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor translation files

Browse Source 
- Add prefixes to all message keys to provide context
- Use messages with attributes for some UI elements (dropdowns, dialogs, checkboxes, menus)
- Rename some class fields for consistency with translation keys
This commit is contained in:
Ivaylo Draganov
2022-11-10 13:46:51 +02:00
committed by Paul Chote
parent 46caa2d889
commit a0f17b15ec
89 changed files with 1095 additions and 1053 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Mods.Common/Widgets/Logic/Editor/ActorEditLogic.cs
View File

@@ -21,13 +21,13 @@ namespace OpenRA.Mods.Common.Widgets.Logic
public class ActorEditLogic : ChromeLogic
{
[TranslationReference]
const string DuplicateActorId = "duplicate-actor-id";
const string DuplicateActorId = "label-duplicate-actor-id";
[TranslationReference]
const string EnterActorId = "enter-actor-id";
const string EnterActorId = "label-actor-id";
[TranslationReference]
const string Owner = "owner";
const string Owner = "label-actor-owner";
// Error states define overlapping bits to simplify panel reflow logic
[Flags]

8
OpenRA.Mods.Common/Widgets/Logic/Editor/ActorSelectorLogic.cs
View File

@@ -21,8 +21,8 @@ namespace OpenRA.Mods.Common.Widgets.Logic
{
public class ActorSelectorLogic : CommonSelectorLogic
{
[TranslationReference]
const string Type = "type";
[TranslationReference("actorType")]
const string ActorTypeTooltip = "label-actor-type";
class ActorSelectorActor
{
@@ -115,8 +115,8 @@ namespace OpenRA.Mods.Common.Widgets.Logic
if (tooltip != null)
searchTerms.Add(tooltip.Name);
var type = modData.Translation.GetString(Type);
var tooltipText = (tooltip == null ? $"{type}: " : tooltip.Name + $"\n{type}: ") + a.Name;
var actorType = modData.Translation.GetString(ActorTypeTooltip, Translation.Arguments("actorType", a.Name));
var tooltipText = tooltip == null ? actorType : tooltip.Name + $"\n{actorType}";
allActorsTemp.Add(new ActorSelectorActor(a, editorData.Categories, searchTerms.ToArray(), tooltipText));
}

8
OpenRA.Mods.Common/Widgets/Logic/Editor/CommonSelectorLogic.cs
View File

@@ -20,16 +20,16 @@ namespace OpenRA.Mods.Common.Widgets.Logic
public abstract class CommonSelectorLogic : ChromeLogic
{
[TranslationReference]
const string None = "none";
const string None = "options-common-selector.none";
[TranslationReference]
const string SearchResults = "search-results";
const string SearchResults = "options-common-selector.search-results";
[TranslationReference]
const string All = "all";
const string All = "options-common-selector.all";
[TranslationReference]
const string Multiple = "multiple";
const string Multiple = "options-common-selector.multiple";
protected readonly Widget Widget;
protected readonly ModData ModData;

20
OpenRA.Mods.Common/Widgets/Logic/Editor/SaveMapLogic.cs
View File

@@ -43,34 +43,34 @@ namespace OpenRA.Mods.Common.Widgets.Logic
}
[TranslationReference]
const string SaveMapFailedTitle = "save-map-failed-title";
const string SaveMapFailedTitle = "dialog-save-map-failed.title";
[TranslationReference]
const string SaveMapFailedPrompt = "save-map-failed-prompt";
const string SaveMapFailedPrompt = "dialog-save-map-failed.prompt";
[TranslationReference]
const string SaveMapFailedAccept = "save-map-failed-accept";
const string SaveMapFailedAccept = "dialog-save-map-failed.confirm";
[TranslationReference]
const string Unpacked = "unpacked";
const string Unpacked = "label-unpacked-map";
[TranslationReference]
const string OverwriteMapFailedTitle = "overwrite-map-failed-title";
const string OverwriteMapFailedTitle = "dialog-overwrite-map-failed.title";
[TranslationReference]
const string OverwriteMapFailedPrompt = "overwrite-map-failed-prompt";
const string OverwriteMapFailedPrompt = "dialog-overwrite-map-failed.prompt";
[TranslationReference]
const string SaveMapFailedConfirm = "overwrite-map-failed-confirm";
const string SaveMapFailedConfirm = "dialog-overwrite-map-failed.confirm";
[TranslationReference]
const string OverwriteMapOutsideEditTitle = "overwrite-map-outside-edit-title";
const string OverwriteMapOutsideEditTitle = "dialog-overwrite-map-outside-edit.title";
[TranslationReference]
const string OverwriteMapOutsideEditPrompt = "overwrite-map-outside-edit-prompt";
const string OverwriteMapOutsideEditPrompt = "dialog-overwrite-map-outside-edit.prompt";
[TranslationReference]
const string SaveMapMapOutsideConfirm = "overwrite-map-outside-edit-confirm";
const string SaveMapMapOutsideConfirm = "dialog-overwrite-map-outside-edit.confirm";
[ObjectCreator.UseCtor]
public SaveMapLogic(Widget widget, ModData modData, Action<string> onSave, Action onExit,