moved InitialFacing from OwnedActor to Unit

OpenRa.Game/Traits/Activities/HeliReturn.cs

@@ -24,7 +24,7 @@ namespace OpenRa.Game.Traits.Activities
 			if (isCanceled) return NextActivity;
 			var dest = ChooseHelipad(self);
 
-			var initialFacing = self.Info.Traits.Get<OwnedActorInfo>().InitialFacing;
+			var initialFacing = self.Info.Traits.Get<UnitInfo>().InitialFacing;
 
 			if (dest == null)
 				return Util.SequenceActivities(

OpenRa.Game/Traits/Building.cs

@@ -14,7 +14,6 @@ namespace OpenRa.Game.Traits
 		public readonly int HP = 0;
 		public readonly ArmorType Armor = ArmorType.none;
 		public readonly bool Crewed = false;		// replace with trait?
-		public readonly int InitialFacing = 128;
 		public readonly int Sight = 0;
 		public readonly bool WaterBound = false;
 	}

OpenRa.Game/Traits/Helicopter.cs

@@ -49,7 +49,7 @@ namespace OpenRa.Game.Traits
 			{
 				self.CancelActivity();
 				self.QueueActivity(new HeliFly(Util.CenterOfCell(order.TargetLocation)));
-				self.QueueActivity( new Turn( self.Info.Traits.GetOrDefault<OwnedActorInfo>().InitialFacing ) );
+				self.QueueActivity( new Turn( self.Info.Traits.GetOrDefault<UnitInfo>().InitialFacing ) );
 				self.QueueActivity(new HeliLand(true));
 			}
 
@@ -66,7 +66,7 @@ namespace OpenRa.Game.Traits
 
 				self.CancelActivity();
 				self.QueueActivity(new HeliFly(order.TargetActor.CenterLocation + offsetVec));
-				self.QueueActivity( new Turn( self.Info.Traits.GetOrDefault<OwnedActorInfo>().InitialFacing ) );
+				self.QueueActivity( new Turn( self.Info.Traits.GetOrDefault<UnitInfo>().InitialFacing ) );
 				self.QueueActivity(new HeliLand(false));
 				self.QueueActivity(order.TargetActor.Info.Name == "hpad"
 					? (IActivity)new Rearm() : new Repair());

OpenRa.Game/Traits/Production.cs

@@ -26,7 +26,7 @@ namespace OpenRa.Game.Traits
 
 		public virtual int CreationFacing( Actor self, Actor newUnit )
 		{
-			return newUnit.Info.Traits.GetOrDefault<OwnedActorInfo>().InitialFacing;
+			return newUnit.Info.Traits.GetOrDefault<UnitInfo>().InitialFacing;
 		}
 
 		public bool Produce( Actor self, NewUnitInfo producee )

OpenRa.Game/Traits/Unit.cs

@@ -4,6 +4,7 @@ namespace OpenRa.Game.Traits
 {
 	class UnitInfo : OwnedActorInfo, ITraitInfo
 	{
+		public readonly int InitialFacing = 128;
 		public readonly int ROT = 0;
 		public readonly int Speed = 0;
 

RulesConverter/Program.cs

@@ -109,7 +109,6 @@ namespace RulesConverter
 					{ "Armor", "Armor" }, 
 					{ "Crewed", "Crewed" },
 					{ "WaterBound", "WaterBound" },
-					{ "InitialFacing", "InitialFacing" },
 					{ "Sight", "Sight" },
 					{ "Unsellable", "Unsellable" } }
 				},

ra.yaml

@@ -789,7 +789,6 @@ GUN:
 		HP: 400
 		Armor: heavy
 		Crewed: yes
-		InitialFacing: 50
 		Sight: 6
 	Turreted:
 		ROT: 12
@@ -820,7 +819,6 @@ AGUN:
 		HP: 400
 		Armor: heavy
 		Crewed: yes
-		InitialFacing: 224
 		Sight: 6
 	Turreted:
 		ROT: 15