Fixed IDisposable implementation and usage.

- Implement IDisposable interface correctly, with sealed classes where possible for simplicity.
- Add using statement around undisposed local variables.
This commit is contained in:
RoosterDragon
2014-05-21 06:19:26 +01:00
parent 334a210231
commit a598a01108
37 changed files with 248 additions and 260 deletions

View File

@@ -15,7 +15,7 @@ using OpenRA.Primitives;
namespace OpenRA.Network
{
public class OrderManager : IDisposable
public sealed class OrderManager : IDisposable
{
readonly SyncReport syncReport;
readonly FrameData frameData = new FrameData();
@@ -197,22 +197,10 @@ namespace OpenRA.Network
++NetFrameNumber;
}
bool disposed;
protected void Dispose(bool disposing)
{
if (disposed)
return;
if (disposing)
Connection.Dispose();
disposed = true;
}
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
if (Connection != null)
Connection.Dispose();
}
}
}