pass target to DoAttack

OpenRA.Mods.RA/Activities/Attack.cs

@@ -60,7 +60,7 @@ namespace OpenRA.Mods.RA.Activities
 			}
 
 			attack.target = Target;
-			attack.DoAttack(self);
+			attack.DoAttack(self, Target);
 			return this;
 		}
 	}

OpenRA.Mods.RA/Activities/FlyAttack.cs

@@ -27,7 +27,7 @@ namespace OpenRA.Mods.RA.Activities
 			if( limitedAmmo != null && !limitedAmmo.HasAmmo() )
 				Cancel( self );
 
-			self.Trait<AttackPlane>().DoAttack( self );
+			self.Trait<AttackPlane>().DoAttack( self, Target );
 
 			if( IsCanceled && inner == null ) return NextActivity;
 

OpenRA.Mods.RA/Activities/HeliAttack.cs

@@ -50,7 +50,7 @@ namespace OpenRA.Mods.RA.Activities
 			if (!float2.WithinEpsilon(float2.Zero, dist, range * Game.CellSize))
 				aircraft.center += (rawSpeed / dist.Length) * dist;
 
-			attack.DoAttack( self );
+			attack.DoAttack( self, target );
 
 			return this;
 		}

OpenRA.Mods.RA/AttackBase.cs

@@ -111,7 +111,7 @@ namespace OpenRA.Mods.RA
 				a();
 		}
 
-		public void DoAttack(Actor self)
+		public void DoAttack(Actor self, Target target)
 		{
 			if( !CanAttack( self ) ) return;
 
@@ -150,7 +150,7 @@ namespace OpenRA.Mods.RA
 			if (order.OrderString == "Attack" || order.OrderString == "Heal")
 			{
 				self.CancelActivity();
-				QueueAttack(self, order);
+				QueueAttack(self, Target.FromOrder(order));
 
 				if (self.Owner == self.World.LocalPlayer)
 					self.World.AddFrameEndTask(w =>
@@ -181,14 +181,14 @@ namespace OpenRA.Mods.RA
 			return (order.OrderString == "Attack" || order.OrderString == "Heal") ? "Attack" : null;
 		}
 		
-		protected virtual void QueueAttack(Actor self, Order order)
+		protected virtual void QueueAttack(Actor self, Target newTarget)
 		{
-			var weapon = ChooseWeaponForTarget(Target.FromOrder(order));
+			var weapon = ChooseWeaponForTarget(newTarget);
 
 			if (weapon != null)
 				self.QueueActivity(
 					new Activities.Attack(
-						Target.FromOrder(order), 
+						newTarget, 
 						Math.Max(0, (int)weapon.Info.Range)));
 		}
 

OpenRA.Mods.RA/AttackHeli.cs

@@ -22,10 +22,10 @@ namespace OpenRA.Mods.RA
 	{
 		public AttackHeli(Actor self) : base(self, 20) { }
 
-		protected override void QueueAttack(Actor self, Order order)
+		protected override void QueueAttack(Actor self, Target newTarget)
 		{
-			target = Target.FromOrder(order);
-			self.QueueActivity(new HeliAttack(target));
+			target = newTarget;
+			self.QueueActivity(new HeliAttack(newTarget));
 		}
 	}
 }

OpenRA.Mods.RA/AttackOmni.cs

@@ -33,12 +33,12 @@ namespace OpenRA.Mods.RA
 		public override void Tick(Actor self)
 		{
 			base.Tick(self);
-			DoAttack(self);
+			DoAttack(self, target);
 		}
 
-		protected override void QueueAttack(Actor self, Order order)
+		protected override void QueueAttack(Actor self, Target newTarget)
 		{
-			target = Target.FromOrder(order);
+			target = newTarget;
 		}
 	}
 }

OpenRA.Mods.RA/AttackPlane.cs

@@ -22,10 +22,10 @@ namespace OpenRA.Mods.RA
 	{
 		public AttackPlane(Actor self) : base(self, 20) { }
 
-		protected override void QueueAttack(Actor self, Order order)
+		protected override void QueueAttack(Actor self, Target newTarget)
 		{
-			target = Target.FromOrder(order);
-			self.QueueActivity(new FlyAttack(target));
+			target = newTarget;
+			self.QueueActivity(new FlyAttack(newTarget));
 		}
 
 		protected override bool CanAttack(Actor self)

OpenRA.Mods.RA/AttackTurreted.cs

@@ -42,23 +42,23 @@ namespace OpenRA.Mods.RA
 		public override void Tick(Actor self)
 		{
 			base.Tick(self);
-			DoAttack( self );
+			DoAttack( self, target );
 		}
 
-		protected override void QueueAttack( Actor self, Order order )
+		protected override void QueueAttack( Actor self, Target newTarget )
 		{
 			if (self.TraitsImplementing<IDisable>().Any(d => d.Disabled))
 				return;
 			
 			const int RangeTolerance = 1;	/* how far inside our maximum range we should try to sit */
-			var weapon = ChooseWeaponForTarget(Target.FromOrder(order));
+			var weapon = ChooseWeaponForTarget(newTarget);
 			if (weapon == null)
 				return;
 
-			target = Target.FromOrder(order);
+			target = newTarget;
 
 			if (self.HasTrait<Mobile>() && !self.Info.Traits.Get<MobileInfo>().OnRails)
-				self.QueueActivity( new Follow( target,
+				self.QueueActivity( new Follow( newTarget,
 					Math.Max( 0, (int)weapon.Info.Range - RangeTolerance ) ) );
 		}
 

OpenRA.Mods.RA/Render/RenderUnitReload.cs

@@ -48,7 +48,7 @@ namespace OpenRA.Mods.RA.Render
 		public override void Tick(Actor self)
 		{
 			var attack = self.TraitOrDefault<AttackBase>();
-			var isAttacking = attack != null && attack.target.IsValid;
+			var isAttacking = attack.IsAttacking;
 			anims["turret_0"].Animation.ReplaceAnim(isAttacking ? "aim" : "turret");
 			base.Tick(self);
 		}