Make perf.log output for ticking things opt-in

Both writing to perf.log frequently as well as GetTimestamp
aren't free and hurt performance particularly on slower systems
(which can have notably higher output to perf.log, further
amplifying the problem).
Therefore we make simulation perf logging opt-in.

Additionally, logging of the current tick and tick type
(local/net) is removed from debug.log, and some
remnant debug logging for kills and pips is removed
to keep performance-sensitive logging limited to
perf.log.
This commit is contained in:
reaperrr
2021-03-21 23:14:09 +01:00
committed by teinarss
parent a1df91b665
commit aa834db1e3
12 changed files with 85 additions and 56 deletions

View File

@@ -11,7 +11,6 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using OpenRA.Primitives;
using OpenRA.Support;
@@ -146,6 +145,7 @@ namespace OpenRA
{
readonly List<Actor> actors = new List<Actor>();
readonly List<T> traits = new List<T>();
readonly PerfTickLogger perfLogger = new PerfTickLogger();
public int Queries { get; private set; }
@@ -298,21 +298,14 @@ namespace OpenRA
public void ApplyToAllTimed(Action<Actor, T> action, string text)
{
var longTickThresholdInStopwatchTicks = PerfTimer.LongTickThresholdInStopwatchTicks;
var start = Stopwatch.GetTimestamp();
perfLogger.Start();
for (var i = 0; i < actors.Count; i++)
{
var actor = actors[i];
var trait = traits[i];
action(actor, trait);
var current = Stopwatch.GetTimestamp();
if (current - start > longTickThresholdInStopwatchTicks)
{
PerfTimer.LogLongTick(start, current, text, trait);
start = Stopwatch.GetTimestamp();
}
else
start = current;
perfLogger.LogTickAndRestartTimer(text, trait);
}
}
}