epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix RCS1192

Browse Source
This commit is contained in:
RoosterDragon
2023-10-29 10:26:33 +00:00
committed by Gustas
parent 11a892f991
commit aa8e85fbf4
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.editorconfig
View File

@@ -1070,6 +1070,9 @@ dotnet_diagnostic.RCS1190.severity = warning
# Declare enum value as combination of names. # Declare enum value as combination of names.
dotnet_diagnostic.RCS1191.severity = warning dotnet_diagnostic.RCS1191.severity = warning
# Unnecessary usage of verbatim string literal.
dotnet_diagnostic.RCS1192.severity = warning
# Overriding member should not change 'params' modifier. # Overriding member should not change 'params' modifier.
dotnet_diagnostic.RCS1193.severity = warning dotnet_diagnostic.RCS1193.severity = warning

10
OpenRA.Test/OpenRA.Game/MiniYamlTest.cs
View File

@@ -544,11 +544,11 @@ Test:
[TestCase(TestName = "Comments are correctly separated from values")] [TestCase(TestName = "Comments are correctly separated from values")]
public void TestEscapedHashInValues() public void TestEscapedHashInValues()
{ {
var trailingWhitespace = MiniYaml.FromString(@"key: value # comment", "trailingWhitespace", discardCommentsAndWhitespace: false)[0]; var trailingWhitespace = MiniYaml.FromString("key: value # comment", "trailingWhitespace", discardCommentsAndWhitespace: false)[0];
Assert.AreEqual("value", trailingWhitespace.Value.Value); Assert.AreEqual("value", trailingWhitespace.Value.Value);
Assert.AreEqual(" comment", trailingWhitespace.Comment); Assert.AreEqual(" comment", trailingWhitespace.Comment);
var noWhitespace = MiniYaml.FromString(@"key:value# comment", "noWhitespace", discardCommentsAndWhitespace: false)[0]; var noWhitespace = MiniYaml.FromString("key:value# comment", "noWhitespace", discardCommentsAndWhitespace: false)[0];
Assert.AreEqual("value", noWhitespace.Value.Value); Assert.AreEqual("value", noWhitespace.Value.Value);
Assert.AreEqual(" comment", noWhitespace.Comment); Assert.AreEqual(" comment", noWhitespace.Comment);
@@ -556,15 +556,15 @@ Test:
Assert.AreEqual("before # after", escapedHashInValue.Value.Value); Assert.AreEqual("before # after", escapedHashInValue.Value.Value);
Assert.AreEqual(" comment", escapedHashInValue.Comment); Assert.AreEqual(" comment", escapedHashInValue.Comment);
var emptyValueAndComment = MiniYaml.FromString(@"key:#", "emptyValueAndComment", discardCommentsAndWhitespace: false)[0]; var emptyValueAndComment = MiniYaml.FromString("key:#", "emptyValueAndComment", discardCommentsAndWhitespace: false)[0];
Assert.AreEqual(null, emptyValueAndComment.Value.Value); Assert.AreEqual(null, emptyValueAndComment.Value.Value);
Assert.AreEqual("", emptyValueAndComment.Comment); Assert.AreEqual("", emptyValueAndComment.Comment);
var noValue = MiniYaml.FromString(@"key:", "noValue", discardCommentsAndWhitespace: false)[0]; var noValue = MiniYaml.FromString("key:", "noValue", discardCommentsAndWhitespace: false)[0];
Assert.AreEqual(null, noValue.Value.Value); Assert.AreEqual(null, noValue.Value.Value);
Assert.AreEqual(null, noValue.Comment); Assert.AreEqual(null, noValue.Comment);
var emptyKey = MiniYaml.FromString(@" : value", "emptyKey", discardCommentsAndWhitespace: false)[0]; var emptyKey = MiniYaml.FromString(" : value", "emptyKey", discardCommentsAndWhitespace: false)[0];
Assert.AreEqual(null, emptyKey.Key); Assert.AreEqual(null, emptyKey.Key);
Assert.AreEqual("value", emptyKey.Value.Value); Assert.AreEqual("value", emptyKey.Value.Value);
Assert.AreEqual(null, emptyKey.Comment); Assert.AreEqual(null, emptyKey.Comment);