epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fail CI on lint warnings

Browse Source
This commit is contained in:
Gustas
2023-05-01 21:43:43 +03:00
committed by Matthias Mailänder
parent 34bcae9abb
commit ade27ad8b9
3 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
OpenRA.Mods.Common/UtilityCommands/CheckYaml.cs
View File

@@ -41,11 +41,14 @@ namespace OpenRA.Mods.Common.UtilityCommands
return true;
}
bool warningAsError = false;
[Desc("[MAPFILE]", "Check a mod or map for certain yaml errors.")]
void IUtilityCommand.Run(Utility utility, string[] args)
{
// HACK: The engine code assumes that Game.modData is set.
var modData = Game.ModData = utility.ModData;
warningAsError = Environment.GetEnvironmentVariable("TREAT_WARNINGS_AS_ERRORS")?.Equals("true", StringComparison.CurrentCultureIgnoreCase) ?? false;
try
{
@@ -77,7 +80,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
try
{
var customPass = (ILintPass)modData.ObjectCreator.CreateBasic(customPassType);
customPass.Run(EmitError, EmitWarning, modData);
customPass.Run(EmitError, warningAsError ? EmitError : EmitWarning, modData);
}
catch (Exception e)
{
@@ -140,7 +143,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
try
{
var customMapPass = (ILintMapPass)modData.ObjectCreator.CreateBasic(customMapPassType);
customMapPass.Run(EmitError, EmitWarning, modData, map);
customMapPass.Run(EmitError, warningAsError ? EmitError : EmitWarning, modData, map);
}
catch (Exception e)
{
@@ -156,7 +159,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
try
{
var customRulesPass = (ILintRulesPass)modData.ObjectCreator.CreateBasic(customRulesPassType);
customRulesPass.Run(EmitError, EmitWarning, modData, rules);
customRulesPass.Run(EmitError, warningAsError ? EmitError : EmitWarning, modData, rules);
}
catch (Exception e)
{
@@ -172,7 +175,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
try
{
var customRulesPass = (ILintSequencesPass)modData.ObjectCreator.CreateBasic(customSequencesPassType);
customRulesPass.Run(EmitError, EmitWarning, modData, rules, sequences);
customRulesPass.Run(EmitError, warningAsError ? EmitError : EmitWarning, modData, rules, sequences);
}
catch (Exception e)
{