epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement Stream.Read(Span<byte>) overloads.

Browse Source 
The default Stream implementation of this method has to rent an array so it can call the overload that accepts an array, and then copy the output over. This is because the array overload is required and the span overload was only added more recently.

We can avoid the overhead of this by implementing the span overload and working with the destination span directly. Do so for all classes we have that derive from Stream, and redirect their array overload to the span overload for code reuse.
This commit is contained in:
RoosterDragon
2023-11-10 20:09:29 +00:00
committed by Paul Chote
parent d05b07a5b0
commit b313f47660
5 changed files with 64 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
OpenRA.Mods.Common/AudioLoaders/OggLoader.cs
View File

@@ -96,9 +96,14 @@ namespace OpenRA.Mods.Common.AudioLoaders
}
public override int Read(byte[] buffer, int offset, int count)
{
return Read(buffer.AsSpan(offset, count));
}
public override int Read(Span<byte> buffer)
{
// Adjust count so it is in 16-bit samples instead of bytes.
count /= 2;
var count = buffer.Length / 2;
// Make sure we don't have an odd count.
count -= count % format.reader.Channels;
@@ -112,8 +117,8 @@ namespace OpenRA.Mods.Common.AudioLoaders
for (var i = 0; i < samples; i++)
{
var conversion = (short)(floatBuffer[i] * 32767);
buffer[offset++] = (byte)(conversion & 255);
buffer[offset++] = (byte)(conversion >> 8);
buffer[i * 2 + 0] = (byte)(conversion & 255);
buffer[i * 2 + 1] = (byte)(conversion >> 8);
}
// Adjust count back to bytes.
@@ -124,6 +129,7 @@ namespace OpenRA.Mods.Common.AudioLoaders
public override long Seek(long offset, SeekOrigin origin) { throw new NotImplementedException(); }
public override void SetLength(long value) { throw new NotImplementedException(); }
public override void Write(byte[] buffer, int offset, int count) { throw new NotImplementedException(); }
public override void Write(ReadOnlySpan<byte> buffer) { throw new NotImplementedException(); }
protected override void Dispose(bool disposing)
{