epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused previous state in AI StateMachine

Browse Source 
The StateMachine offered a feature to remember the previous state and allow reverting to it. However this feature is unused. Remove it to allow the previous states to be reclaimed by the GC earlier.
This commit is contained in:
RoosterDragon
2024-07-06 12:17:41 +01:00
committed by Gustas
parent c1de85f700
commit b3168928c6
5 changed files with 23 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
OpenRA.Mods.Common/Traits/BotModules/Squads/StateMachine.cs
View File

@@ -14,18 +14,14 @@ namespace OpenRA.Mods.Common.Traits.BotModules.Squads
sealed class StateMachine
{
IState currentState;
IState previousState;
public void Update(Squad squad)
{
currentState?.Tick(squad);
}
public void ChangeState(Squad squad, IState newState, bool rememberPrevious)
public void ChangeState(Squad squad, IState newState)
{
if (rememberPrevious)
previousState = currentState;
currentState?.Deactivate(squad);
if (newState != null)
@@ -33,11 +29,6 @@ namespace OpenRA.Mods.Common.Traits.BotModules.Squads
currentState?.Activate(squad);
}
public void RevertToPreviousState(Squad squad, bool saveCurrentState)
{
ChangeState(squad, previousState, saveCurrentState);
}
}
interface IState