Yet more fixes to network.

OpenRa.Game/OrderManager.cs

@@ -147,7 +147,7 @@ namespace OpenRa.Game
 		int nextLocalOrderFrame = 0;
 		TcpClient socket;
 
-		Dictionary<int, List<Order>> orders = new Dictionary<int,List<Order>>();
+		Dictionary<int, byte[]> orderBuffers = new Dictionary<int, byte[]>();
 
 		public NetworkOrderSource( TcpClient socket )
 		{
@@ -168,27 +168,37 @@ namespace OpenRa.Game
 				var ret = new List<Order>();
 				while( true )
 				{
-					var first = reader.ReadUInt32();
+					var len = reader.ReadInt32();
-					if( first == currentFrame + 1 )
+					var buf = reader.ReadBytes( len );
-					{
+
-						lock( orders )
+					lock( orderBuffers )
-							orders[ currentFrame ] = ret;
+						orderBuffers[ currentFrame ] = buf;
-						ret = new List<Order>();
 					++currentFrame;
 				}
-					else if( first < 0x80000000 )
-						throw new InvalidOperationException( "Attempted time-travel in network thread" );
-					else
-						ret.Add( Order.Deserialize( reader, first ) );
-				}
 			} ) { IsBackground = true }.Start();
 		}
 
 		public List<Order> OrdersForFrame( int currentFrame )
 		{
-			// TODO: prune `orders` based on currentFrame.
+			// TODO: prune `orderBuffers` based on currentFrame.
-			lock( orders )
+			byte[] orderBuffer;
-				return orders[ currentFrame ];
+			lock( orderBuffers )
+				orderBuffer = orderBuffers[ currentFrame ];
+
+			var ms = new MemoryStream( orderBuffer );
+			var reader = new BinaryReader( ms );
+			var ret = new List<Order>();
+
+			if( reader.ReadUInt32() != currentFrame )
+				throw new InvalidOperationException( "Attempted time-travel in OrdersForFrame (network)" );
+
+			while( ms.Position < ms.Length )
+			{
+				var first = reader.ReadUInt32();
+				ret.Add( Order.Deserialize( reader, first ) );
+			}
+
+			return ret;
 		}
 
 		public void SendLocalOrders( int localFrame, List<Order> localOrders )
@@ -196,21 +206,31 @@ namespace OpenRa.Game
 			if( nextLocalOrderFrame != localFrame )
 				throw new InvalidOperationException( "Attempted time-travel in NetworkOrderSource.SendLocalOrders()" );
 
+			var ms = new MemoryStream();
+
+			ms.Write( System.BitConverter.GetBytes( nextLocalOrderFrame ) );
+
 			foreach( var order in localOrders )
-			{
+				ms.Write( order.Serialize() );
-				var bytes = order.Serialize();
-				socket.GetStream().Write( bytes, 0, bytes.Length );
-			}
 
 			++nextLocalOrderFrame;
-			var nextFrameId = System.BitConverter.GetBytes( nextLocalOrderFrame );
+
-			socket.GetStream().Write( nextFrameId, 0, nextFrameId.Length );
+			socket.GetStream().Write( System.BitConverter.GetBytes( (int)ms.Length ) );
+			ms.WriteTo( socket.GetStream() );
 		}
 
 		public bool IsReadyForFrame( int frameNumber )
 		{
-			lock( orders )
+			lock( orderBuffers )
-				return orders.ContainsKey( frameNumber );
+				return orderBuffers.ContainsKey( frameNumber );
+		}
+	}
+
+	static class StreamExts
+	{
+		public static void Write( this Stream s, byte[] buf )
+		{
+			s.Write( buf, 0, buf.Length );
 		}
 	}
 }