epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve names and test code in ActorInfoTest.

Browse Source
This commit is contained in:
RoosterDragon
2016-03-11 21:30:19 +00:00
parent 2c15bc9308
commit b3b816fcc6
1 changed files with 16 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
OpenRA.Test/OpenRA.Game/ActorInfoTest.cs
View File

@@ -31,8 +31,8 @@ namespace OpenRA.Test
[TestFixture] [TestFixture]
public class ActorInfoTest public class ActorInfoTest
{ {
[TestCase(TestName = "Sort traits in order of dependency")] [TestCase(TestName = "Trait ordering sorts in dependency order correctly")]
public void TraitsInConstructOrderA() public void TraitOrderingSortsCorrectly()
{ {
var actorInfo = new ActorInfo("test", new MockCInfo(), new MockBInfo(), new MockAInfo()); var actorInfo = new ActorInfo("test", new MockCInfo(), new MockBInfo(), new MockAInfo());
@@ -43,48 +43,28 @@ namespace OpenRA.Test
Assert.That(i[2].GetType().Name, Is.EqualTo("MockCInfo")); Assert.That(i[2].GetType().Name, Is.EqualTo("MockCInfo"));
} }
[TestCase(TestName = "Exception reports missing dependencies")] [TestCase(TestName = "Trait ordering exception reports missing dependencies")]
public void TraitsInConstructOrderB() public void TraitOrderingReportsMissingDependencies()
{ {
var actorInfo = new ActorInfo("test", new MockBInfo(), new MockCInfo()); var actorInfo = new ActorInfo("test", new MockBInfo(), new MockCInfo());
var ex = Assert.Throws<Exception>(() => actorInfo.TraitsInConstructOrder());
try StringAssert.Contains(typeof(MockAInfo).Name, ex.Message, "Exception message did not report a missing dependency.");
{ StringAssert.Contains(typeof(MockBInfo).Name, ex.Message, "Exception message did not report a missing dependency.");
actorInfo.TraitsInConstructOrder(); StringAssert.Contains(typeof(MockCInfo).Name, ex.Message, "Exception message did not report a missing dependency.");
throw new Exception("Exception not thrown!"); StringAssert.Contains(typeof(MockInheritInfo).Name, ex.Message, "Exception message did not report a missing dependency (from a base class).");
} StringAssert.Contains(typeof(IMock).Name, ex.Message, "Exception message did not report a missing dependency (from an interface).");
catch (Exception e)
{
// Is.StringContaining is deprecated in NUnit 3, but we need to support NUnit 2 so we ignore the warning.
#pragma warning disable CS0618
Assert.That(e.Message, Is.StringContaining("MockA"));
Assert.That(e.Message, Is.StringContaining("MockB"));
Assert.That(e.Message, Is.StringContaining("MockC"));
Assert.That(e.Message, Is.StringContaining("MockInherit"), "Should recognize base classes");
Assert.That(e.Message, Is.StringContaining("IMock"), "Should recognize interfaces");
#pragma warning restore CS0618
}
} }
[TestCase(TestName = "Exception reports cyclic dependencies")] [TestCase(TestName = "Trait ordering exception reports cyclic dependencies")]
public void TraitsInConstructOrderC() public void TraitOrderingReportsCyclicDependencies()
{ {
var actorInfo = new ActorInfo("test", new MockDInfo(), new MockEInfo(), new MockFInfo()); var actorInfo = new ActorInfo("test", new MockDInfo(), new MockEInfo(), new MockFInfo());
var ex = Assert.Throws<Exception>(() => actorInfo.TraitsInConstructOrder());
try StringAssert.Contains(typeof(MockDInfo).Name, ex.Message, "Exception message should report all cyclic dependencies.");
{ StringAssert.Contains(typeof(MockEInfo).Name, ex.Message, "Exception message should report all cyclic dependencies.");
actorInfo.TraitsInConstructOrder(); StringAssert.Contains(typeof(MockFInfo).Name, ex.Message, "Exception message should report all cyclic dependencies.");
throw new Exception("Exception not thrown!");
}
catch (Exception e)
{
var count = (
new Regex("MockD").Matches(e.Message).Count +
new Regex("MockE").Matches(e.Message).Count +
new Regex("MockF").Matches(e.Message).Count) / 3.0;
Assert.That(count, Is.EqualTo(Math.Floor(count)), "Should be symmetrical");
}
} }
} }
} }