From b67954451aa0401c04d01916ce6d044c272c96a3 Mon Sep 17 00:00:00 2001 From: penev92 Date: Sun, 14 Nov 2021 02:15:42 +0200 Subject: [PATCH] Removed obsolete file OpenRA.sln.DotSettings - The DEFAULT_PRIVATE_MODIFIER behaviour is now handled by the .editorconfig file via `dotnet_style_require_accessibility_modifiers = omit_if_default:warning`. Also added `dotnet_diagnostic.IDE0040.severity = warning` there to raise compile-time errors in the CI. - The field naming conventions seem to already be covered by (some) analyzer rules (checked in both VS and VSCode) - IDE1006/SA1306 and SA1307. --- .editorconfig | 5 +++++ OpenRA.sln.DotSettings | 4 ---- 2 files changed, 5 insertions(+), 4 deletions(-) delete mode 100644 OpenRA.sln.DotSettings diff --git a/.editorconfig b/.editorconfig index e948040ce6..5d0a0af252 100644 --- a/.editorconfig +++ b/.editorconfig @@ -106,6 +106,11 @@ dotnet_style_predefined_type_for_member_access = true:suggestion #prefer the language keyword for local variables, method parameters, and class members, instead of the type name, for types that have a keyword to represent them dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion +#show an IDE warning when default access modifiers are explicitly specified +dotnet_style_require_accessibility_modifiers = omit_if_default:warning +#raise a warning on build when default access modifiers are explicitly specified +dotnet_diagnostic.IDE0040.severity = warning + #don't prefer braces (for one liners) dotnet_diagnostic.IDE0011.severity = none diff --git a/OpenRA.sln.DotSettings b/OpenRA.sln.DotSettings deleted file mode 100644 index d9e7d4be45..0000000000 --- a/OpenRA.sln.DotSettings +++ /dev/null @@ -1,4 +0,0 @@ - - Implicit - <Policy Inspect="True" Prefix="" Suffix="" Style="aaBb" /> - <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /> \ No newline at end of file