epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix integer overflows in Wangle.ArcTan.

Browse Source
This commit is contained in:
Paul Chote
2016-09-25 21:24:34 +01:00
parent b7dd321550
commit b680a97d2c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Game/WAngle.cs
View File

@@ -91,11 +91,13 @@ namespace OpenRA
var ax = Math.Abs(x); var ax = Math.Abs(x);
// Find the closest angle that satisfies y = x*tan(theta) // Find the closest angle that satisfies y = x*tan(theta)
var bestVal = int.MaxValue; // Uses a long to store bestVal to eliminate integer overflow issues in the common cases
// (may still fail for unrealistically large ax and ay)
var bestVal = long.MaxValue;
var bestAngle = 0; var bestAngle = 0;
for (var i = 0; i < 256; i += stride) for (var i = 0; i < 256; i += stride)
{ {
var val = Math.Abs(1024 * ay - ax * TanTable[i]); var val = Math.Abs(1024 * ay - (long)ax * TanTable[i]);
if (val < bestVal) if (val < bestVal)
{ {
bestVal = val; bestVal = val;