General uncontroversial cleanup:
- Made private methods static where possible (runtime can elide checking the object for null). - Declared attribute classes as sealed (allows reflection on attributes to complete faster). - Moved some static cctor's into field initializers (static cctor's are slower than static field initializers). - Made classes static if they contained only static methods (can't create instances of useless objects). - Use inferable Exts.Lazy and not new Lazy<T>(). - Added required STAThread attribute to CrashDialog. - Removed unused parameters in private methods. - Added Serializable attribute to exceptions. - Added parameter name in calls to ArgumentNullException. - Use of as operator instead of is + cast. - Changed (x as Foo).Bar anti-pattern into ((Foo)x).Bar. Results in sensible cast exceptions on error rather than null dereferences. - Removed unused method in NullShader.
This commit is contained in:
@@ -47,7 +47,7 @@ namespace OpenRA.Mods.RA
|
||||
new TypeDictionary { new OwnerInit(self.Owner), new LocationInit(self.Location) });
|
||||
|
||||
|
||||
if (IsSuitableCell(self, pilot, self.Location))
|
||||
if (IsSuitableCell(self, pilot))
|
||||
{
|
||||
if (cp.Z > 0)
|
||||
{
|
||||
@@ -66,7 +66,7 @@ namespace OpenRA.Mods.RA
|
||||
pilot.Destroy();
|
||||
}
|
||||
|
||||
bool IsSuitableCell(Actor self, Actor actorToDrop, CPos p)
|
||||
static bool IsSuitableCell(Actor self, Actor actorToDrop)
|
||||
{
|
||||
return actorToDrop.Trait<IPositionable>().CanEnterCell(self.Location, self, true);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user