per tileset configurable selection overlays

don't use a white one for more contrast on snow, closes #2050

OpenRA.Mods.RA/Orders/PlaceBuildingOrderGenerator.cs

@@ -30,9 +30,10 @@ namespace OpenRA.Mods.RA.Orders
 		{
 			Producer = producer;
 			Building = name;
+			var tileset = producer.World.TileSet.Id.ToLower();
 			BuildingInfo = Rules.Info[Building].Traits.Get<BuildingInfo>();
 
-			buildOk = SequenceProvider.GetSequence("overlay", "build-valid").GetSprite(0);
+			buildOk = SequenceProvider.GetSequence("overlay", "build-valid-{0}".F(tileset)).GetSprite(0);
 			buildBlocked = SequenceProvider.GetSequence("overlay", "build-invalid").GetSprite(0);
 		}
 

OpenRA.Mods.RA/SupportPowers/ChronoshiftPower.cs

@@ -178,7 +178,8 @@ namespace OpenRA.Mods.RA
 				this.sourceLocation = sourceLocation;
 				this.range = (power.Info as ChronoshiftPowerInfo).Range;
 
-				validTile = SequenceProvider.GetSequence("overlay", "target-valid").GetSprite(0);
+				var tileset = manager.self.World.TileSet.Id.ToLower();
+				validTile = SequenceProvider.GetSequence("overlay", "target-valid-{0}".F(tileset)).GetSprite(0);
 				invalidTile = SequenceProvider.GetSequence("overlay", "target-invalid").GetSprite(0);
 				sourceTile = SequenceProvider.GetSequence("overlay", "target-select").GetSprite(0);
 			}

mods/cnc/sequences/misc.yaml

@@ -264,13 +264,25 @@ pips:
 		Length: *
 
 overlay:
-	build-valid:
+	build-valid-desert:
+		Start: 0
+	build-valid-snow:
+		Start: 2
+	build-valid-temperat:
+		Start: 0
+	build-valid-winter:
 		Start: 0
 	build-invalid:
 		Start: 1
 	target-select:
+		Start: 3
+	target-valid-desert:
+		Start: 0
+	target-valid-snow:
 		Start: 2
-	target-valid:
+	target-valid-temperat:
+		Start: 0
+	target-valid-winter:
 		Start: 0
 	target-invalid:
 		Start: 1

mods/d2k/sequences.yaml

@@ -1080,13 +1080,13 @@ rank:
 		Length: *
 
 overlay:
-	build-valid:
+	build-valid-arrakis:
 		Start: 0
 	build-invalid:
 		Start: 1
 	target-select:
 		Start: 2
-	target-valid:
+	target-valid-arrakis:
 		Start: 0
 	target-invalid:
 		Start: 1

mods/ra/sequences.yaml

@@ -2559,13 +2559,25 @@ gpsdot:
 		Start: 5
 
 overlay:
-	build-valid:
+	build-valid-desert:
+		Start: 0
+	build-valid-interior:
+		Start: 0
+	build-valid-snow:
+		Start: 2
+	build-valid-temperat:
 		Start: 0
 	build-invalid:
 		Start: 1
 	target-select:
 		Start: 2
-	target-valid:
+	target-valid-desert:
+		Start: 0
+	target-valid-interior:
+		Start: 0
+	target-valid-snow:
+		Start: 2
+	target-valid-temperat:
 		Start: 0
 	target-invalid:
 		Start: 1