Add a check for bogus Frames / Length combinations.

2016-08-06 21:19:32 +01:00
parent de85a76c90
commit b94b703157
1 changed files with 5 additions and 0 deletions
--- a/OpenRA.Mods.Common/Graphics/DefaultSpriteSequence.cs
+++ b/OpenRA.Mods.Common/Graphics/DefaultSpriteSequence.cs
@@ -254,6 +254,11 @@ namespace OpenRA.Mods.Common.Graphics
 						"{0}: Sequence {1}.{2}: Length must be <= stride"
 						.F(info.Nodes[0].Location, sequence, animation));

+				if (Frames != null && Length > Frames.Length)
+					throw new InvalidOperationException(
+						"{0}: Sequence {1}.{2}: Length must be <= Frames.Length"
+						.F(info.Nodes[0].Location, sequence, animation));
+
 				if (Start < 0 || Start + Facings * Stride > sprites.Length)
 					throw new InvalidOperationException(
 						"{5}: Sequence {0}.{1} uses frames [{2}..{3}], but only 0..{4} actually exist"