epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Display the line where a mismatch occurred.

Browse Source
This commit is contained in:
Matthias Mailänder
2025-12-21 15:59:10 +01:00
committed by Gustas Kažukauskas
parent dd14d72ed3
commit c063e16c51
1 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
OpenRA.Mods.Common/Lint/CheckRunningUpdateRule.cs
View File

@@ -12,7 +12,6 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Text;
using OpenRA.Mods.Common.UpdateRules; using OpenRA.Mods.Common.UpdateRules;
using OpenRA.Mods.Common.UpdateRules.Rules; using OpenRA.Mods.Common.UpdateRules.Rules;
@@ -35,9 +34,27 @@ namespace OpenRA.Mods.Common.Lint
if (package == null) if (package == null)
continue; continue;
var textData = Encoding.UTF8.GetBytes(nodes.WriteToString()); var textData = nodes.WriteToString();
if (!Enumerable.SequenceEqual(textData, package.GetStream(file).ReadAllBytes())) var packagesStream = package.GetStream(file);
emitError($"Mock update rule has tried to modify file {file}. Syntax mismatch detected."); var packageData = packagesStream.ReadAllText();
if (!Enumerable.SequenceEqual(textData, packageData))
{
emitError($"Mock update rule has tried to modify file {file}.");
var packageLines = packageData.Split(["\r\n", "\n"], StringSplitOptions.None).GetEnumerator();
var textLines = textData.Split(["\r\n", "\n"], StringSplitOptions.None).GetEnumerator();
var n = 1;
#pragma warning disable RCS1239
while (packageLines.MoveNext() && textLines.MoveNext())
{
if ((string)packageLines.Current != (string)textLines.Current)
emitError($"Syntax or whitespace mismatch detected at line {n}.");
n++;
}
#pragma warning restore RCS1239
}
} }
} }
catch (Exception ex) catch (Exception ex)