epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Repulsion performance optimizations

Browse Source 
`cruising` is updated  on every position change,
so we can safely re-use it instead of
performing another DAT check.
Additionally, if repulsion force is
horizontally zero, it's guaranteed to be WVec.Zero,
so we can save that conversion too.
This commit is contained in:
reaperrr
2019-05-04 12:11:21 +02:00
committed by reaperrr
parent 83b4e448c8
commit c24398e32c
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
OpenRA.Mods.Common/Traits/Air/Aircraft.cs
View File

@@ -350,7 +350,7 @@ namespace OpenRA.Mods.Common.Traits
public void Repulse() public void Repulse()
{ {
var repulsionForce = GetRepulsionForce(); var repulsionForce = GetRepulsionForce();
if (repulsionForce.HorizontalLengthSquared == 0) if (repulsionForce == WVec.Zero)
return; return;
var speed = Info.RepulsionSpeed != -1 ? Info.RepulsionSpeed : MovementSpeed; var speed = Info.RepulsionSpeed != -1 ? Info.RepulsionSpeed : MovementSpeed;
@@ -369,9 +369,8 @@ namespace OpenRA.Mods.Common.Traits
return WVec.Zero; return WVec.Zero;
} }
// Repulsion only applies when we're flying! // Repulsion only applies when we're flying at CruiseAltitude!
var altitude = self.World.Map.DistanceAboveTerrain(CenterPosition).Length; if (!cruising)
if (altitude != Info.CruiseAltitude.Length)
return WVec.Zero; return WVec.Zero;
// PERF: Avoid LINQ. // PERF: Avoid LINQ.
@@ -1038,6 +1037,7 @@ namespace OpenRA.Mods.Common.Traits
{ {
if (!cruising) if (!cruising)
return; return;
cruising = false; cruising = false;
if (conditionManager != null && cruisingToken != ConditionManager.InvalidConditionToken) if (conditionManager != null && cruisingToken != ConditionManager.InvalidConditionToken)
cruisingToken = conditionManager.RevokeCondition(self, cruisingToken); cruisingToken = conditionManager.RevokeCondition(self, cruisingToken);