epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CA1854

Browse Source
This commit is contained in:
RoosterDragon
2023-11-15 19:46:36 +00:00
committed by Pavel Penev
parent c2568ebd1f
commit c8efc5fdd7
19 changed files with 44 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
OpenRA.Game/UtilityCommands/ExtractChromeStrings.cs
View File

@@ -257,10 +257,10 @@ namespace OpenRA.UtilityCommands
var validChildTypes = new List<(MiniYamlNodeBuilder Node, string Type, string Value)>();
foreach (var childNode in node.Value.Nodes)
{
if (translatables.ContainsKey(nodeType))
if (translatables.TryGetValue(nodeType, out var fieldName))
{
var childType = childNode.Key.Split('@')[0];
if (translatables[nodeType].Contains(childType)
if (fieldName.Contains(childType)
&& !string.IsNullOrEmpty(childNode.Value.Value)
&& !IsAlreadyTranslated(childNode.Value.Value)
&& childNode.Value.Value.Any(char.IsLetterOrDigit))