epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Presize MemoryStream when possible.

Browse Source 
Also use GetBuffer when we know we have presized the stream to the exact required size to prevent a needless copy.
This commit is contained in:
RoosterDragon
2017-12-07 21:28:43 +00:00
committed by abcdefg30
parent 5d8c9a560a
commit ca01a1f186
7 changed files with 19 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
OpenRA.Game/Network/Connection.cs
View File

@@ -77,10 +77,10 @@ namespace OpenRA.Network
public virtual void SendSync(int frame, byte[] syncData)
{
var ms = new MemoryStream();
var ms = new MemoryStream(4 + syncData.Length);
ms.Write(BitConverter.GetBytes(frame));
ms.Write(syncData);
Send(ms.ToArray());
Send(ms.GetBuffer());
}
protected virtual void Send(byte[] packet)
@@ -197,10 +197,10 @@ namespace OpenRA.Network
public override void SendSync(int frame, byte[] syncData)
{
var ms = new MemoryStream();
var ms = new MemoryStream(4 + syncData.Length);
ms.Write(BitConverter.GetBytes(frame));
ms.Write(syncData);
queuedSyncPackets.Add(ms.ToArray());
queuedSyncPackets.Add(ms.GetBuffer());
}
protected override void Send(byte[] packet)

2
OpenRA.Game/Network/Order.cs
View File

@@ -240,7 +240,7 @@ namespace OpenRA
{
if (IsImmediate)
{
var ret = new MemoryStream();
var ret = new MemoryStream(1 + OrderString.Length + 1 + TargetString.Length + 1);
var w = new BinaryWriter(ret);
w.Write((byte)0xfe);
w.Write(OrderString);

4
OpenRA.Game/Network/OrderIO.cs
View File

@@ -38,14 +38,14 @@ namespace OpenRA.Network
public static byte[] SerializeSync(int sync)
{
var ms = new MemoryStream();
var ms = new MemoryStream(1 + 4);
using (var writer = new BinaryWriter(ms))
{
writer.Write((byte)0x65);
writer.Write(sync);
}
return ms.ToArray();
return ms.GetBuffer();
}
public static int2 ReadInt2(this BinaryReader r)

4
OpenRA.Game/Network/ReplayConnection.cs
View File

@@ -127,10 +127,10 @@ namespace OpenRA.Network
public void SendSync(int frame, byte[] syncData)
{
var ms = new MemoryStream();
var ms = new MemoryStream(4 + syncData.Length);
ms.Write(BitConverter.GetBytes(frame));
ms.Write(syncData);
sync.Add(ms.ToArray());
sync.Add(ms.GetBuffer());
// Store the current frame so Receive() can return the next chunk of orders.
ordersFrame = frame + LobbyInfo.GlobalSettings.OrderLatency;