epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a division by zero error in FindAndDeliverResources

Browse Source 
by preventing an overflow through dividing directly
This commit is contained in:
abcdefg30
2019-09-05 15:11:18 +02:00
committed by Paul Chote
parent aff3bf369b
commit ca8ca2df5c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OpenRA.Mods.Common/Activities/FindAndDeliverResources.cs
View File

@@ -214,7 +214,7 @@ namespace OpenRA.Mods.Common.Activities
if (b != WVec.Zero && c != WVec.Zero) if (b != WVec.Zero && c != WVec.Zero)
{ {
var cosA = (int)(1024 * (b.LengthSquared + c.LengthSquared - a.LengthSquared) / (2 * b.Length * c.Length)); var cosA = (int)(512 * (b.LengthSquared + c.LengthSquared - a.LengthSquared) / b.Length / c.Length);
// Cost modifier varies between 0 and ResourceRefineryDirectionPenalty // Cost modifier varies between 0 and ResourceRefineryDirectionPenalty
return Math.Abs(harvInfo.ResourceRefineryDirectionPenalty / 2) + harvInfo.ResourceRefineryDirectionPenalty * cosA / 2048; return Math.Abs(harvInfo.ResourceRefineryDirectionPenalty / 2) + harvInfo.ResourceRefineryDirectionPenalty * cosA / 2048;