epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable MP sync report generation by default.

Browse Source 
A new Server.EnableSyncReports option is provided
so that server operators can restore them remotely
in the event of a future desync bug.
This commit is contained in:
Paul Chote
2018-11-25 21:59:36 +00:00
committed by reaperrr
parent 081182b60f
commit cc707f0037
4 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
OpenRA.Game/Network/OrderManager.cs
View File

@@ -14,6 +14,7 @@ using System.Collections.Generic;
using System.Drawing; using System.Drawing;
using System.Linq; using System.Linq;
using OpenRA.Primitives; using OpenRA.Primitives;
using OpenRA.Support;
namespace OpenRA.Network namespace OpenRA.Network
{ {
@@ -67,7 +68,7 @@ namespace OpenRA.Network
// Generating sync reports is expensive, so only do it if we have // Generating sync reports is expensive, so only do it if we have
// other players to compare against if a desync did occur // other players to compare against if a desync did occur
generateSyncReport = !(Connection is ReplayConnection) && LobbyInfo.NonBotClients.Count() > 1; generateSyncReport = !(Connection is ReplayConnection) && LobbyInfo.GlobalSettings.EnableSyncReports;
NetFrameNumber = 1; NetFrameNumber = 1;
for (var i = NetFrameNumber; i <= FramesAhead; i++) for (var i = NetFrameNumber; i <= FramesAhead; i++)

1
OpenRA.Game/Network/Session.cs
View File

@@ -201,6 +201,7 @@ namespace OpenRA.Network
public bool AllowVersionMismatch; public bool AllowVersionMismatch;
public string GameUid; public string GameUid;
public bool EnableSingleplayer; public bool EnableSingleplayer;
public bool EnableSyncReports;
public bool Dedicated; public bool Dedicated;
[FieldLoader.Ignore] [FieldLoader.Ignore]

1
OpenRA.Game/Server/Server.cs
View File

@@ -157,6 +157,7 @@ namespace OpenRA.Server
Map = settings.Map, Map = settings.Map,
ServerName = settings.Name, ServerName = settings.Name,
EnableSingleplayer = settings.EnableSingleplayer || !dedicated, EnableSingleplayer = settings.EnableSingleplayer || !dedicated,
EnableSyncReports = settings.EnableSyncReports,
GameUid = Guid.NewGuid().ToString(), GameUid = Guid.NewGuid().ToString(),
Dedicated = dedicated Dedicated = dedicated
} }

3
OpenRA.Game/Settings.cs
View File

@@ -74,6 +74,9 @@ namespace OpenRA
[Desc("Query map information from the Resource Center if they are not available locally.")] [Desc("Query map information from the Resource Center if they are not available locally.")]
public bool QueryMapRepository = true; public bool QueryMapRepository = true;
[Desc("Enable client-side report generation to help debug desync errors.")]
public bool EnableSyncReports = false;
public string TimestampFormat = "s"; public string TimestampFormat = "s";
public ServerSettings Clone() public ServerSettings Clone()