Remove custom palettes from building placement previews.

OpenRA.Mods.Common/UpdateRules/Rules/20201213/RemovePlaceBuildingPalette.cs

@@ -0,0 +1,77 @@
+#region Copyright & License Information
+/*
+ * Copyright 2007-2020 The OpenRA Developers (see AUTHORS)
+ * This file is part of OpenRA, which is free software. It is made
+ * available to you under the terms of the GNU General Public License
+ * as published by the Free Software Foundation, either version 3 of
+ * the License, or (at your option) any later version. For more
+ * information, see COPYING.
+ */
+#endregion
+
+using System.Collections.Generic;
+using System.Linq;
+
+namespace OpenRA.Mods.Common.UpdateRules.Rules
+{
+	public class RemovePlaceBuildingPalette : UpdateRule
+	{
+		public override string Name { get { return "*PlaceBuildingPreview palette overrides have been removed."; } }
+
+		public override string Description
+		{
+			get
+			{
+				return "The palette overrides on the ActorPreviewPlaceBuildingPreview, FootprintPlaceBuildingPreview\n" +
+					"SequencePlaceBuildingPreview, and D2kActorPreviewPlaceBuildingPreview traits have been removed.\n" +
+					"New Alpha and LineBuildSegmentAlpha properties have been added in their place.";
+			}
+		}
+
+		readonly List<string> locations = new List<string>();
+
+		public override IEnumerable<string> AfterUpdate(ModData modData)
+		{
+			if (locations.Any())
+				yield return "The *Palette fields have been removed from the *PlaceBuildingPreview traits.\n" +
+				             "You may wish to inspect the following definitions and define new Alpha or\n" +
+				             "LineBuildSegmentAlpha properties as appropriate to recreate transparency effects:\n" +
+				             UpdateUtils.FormatMessageList(locations);
+
+			locations.Clear();
+		}
+
+		public override IEnumerable<string> UpdateActorNode(ModData modData, MiniYamlNode actorNode)
+		{
+			var removed = 0;
+			foreach (var node in actorNode.ChildrenMatching("ActorPreviewPlaceBuildingPreview"))
+			{
+				removed += node.RemoveNodes("OverridePalette");
+				removed += node.RemoveNodes("OverridePaletteIsPlayerPalette");
+				removed += node.RemoveNodes("LineBuildSegmentPalette");
+			}
+
+			foreach (var node in actorNode.ChildrenMatching("D2kActorPreviewPlaceBuildingPreview"))
+			{
+				removed += node.RemoveNodes("OverridePalette");
+				removed += node.RemoveNodes("OverridePaletteIsPlayerPalette");
+				removed += node.RemoveNodes("LineBuildSegmentPalette");
+			}
+
+			foreach (var node in actorNode.ChildrenMatching("FootprintPlaceBuildingPreview"))
+				removed += node.RemoveNodes("LineBuildSegmentPalette");
+
+			foreach (var node in actorNode.ChildrenMatching("SequencePlaceBuildingPreview"))
+			{
+				removed += node.RemoveNodes("SequencePalette");
+				removed += node.RemoveNodes("SequencePaletteIsPlayerPalette");
+				removed += node.RemoveNodes("LineBuildSegmentPalette");
+			}
+
+			if (removed > 0)
+				locations.Add("{0} ({1})".F(actorNode.Key, actorNode.Location.Filename));
+
+			yield break;
+		}
+	}
+}

OpenRA.Mods.Common/UpdateRules/UpdatePath.cs

@@ -88,6 +88,7 @@ namespace OpenRA.Mods.Common.UpdateRules
 				new RemovePlayerHighlightPalette(),
 				new ReplaceWithColoredOverlayPalette(),
 				new RemoveRenderSpritesScale(),
+				new RemovePlaceBuildingPalette(),
 			})
 		};