epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix RCS1049

Browse Source
This commit is contained in:
RoosterDragon
2023-03-18 12:04:38 +00:00
committed by Gustas
parent 9f1ea57d3c
commit d1dc6293e8
4 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.editorconfig
View File

@@ -971,6 +971,9 @@ dotnet_diagnostic.RCS1043.severity = warning
# Use lambda expression instead of anonymous method. # Use lambda expression instead of anonymous method.
dotnet_diagnostic.RCS1048.severity = warning dotnet_diagnostic.RCS1048.severity = warning
# Simplify boolean comparison.
dotnet_diagnostic.RCS1049.severity = warning
# Avoid locking on publicly accessible instance. # Avoid locking on publicly accessible instance.
dotnet_diagnostic.RCS1059.severity = warning dotnet_diagnostic.RCS1059.severity = warning

2
OpenRA.Mods.Cnc/UtilityCommands/Glob.cs
View File

@@ -65,7 +65,7 @@ namespace OpenRA.Mods.Cnc.UtilityCommands
if (parts.Count == 0 if (parts.Count == 0
|| (parts[0][0] != Path.DirectorySeparatorChar || (parts[0][0] != Path.DirectorySeparatorChar
&& parts[0][0] != Path.AltDirectorySeparatorChar && parts[0][0] != Path.AltDirectorySeparatorChar
&& parts[0].Contains(':') == false && !parts[0].Contains(':')
&& parts[0] != "." + Path.DirectorySeparatorChar && parts[0] != "." + Path.DirectorySeparatorChar
&& parts[0] != "." + Path.AltDirectorySeparatorChar && parts[0] != "." + Path.AltDirectorySeparatorChar
&& parts[0] != ".." + Path.DirectorySeparatorChar && parts[0] != ".." + Path.DirectorySeparatorChar

2
OpenRA.Mods.Common/Traits/Player/TechTree.cs
View File

@@ -171,7 +171,7 @@ namespace OpenRA.Mods.Common.Traits
var nowHasPrerequisites = !hasReachedLimit && HasPrerequisites(ownedPrerequisites); var nowHasPrerequisites = !hasReachedLimit && HasPrerequisites(ownedPrerequisites);
var nowHidden = IsHidden(ownedPrerequisites); var nowHidden = IsHidden(ownedPrerequisites);
if (initialized == false) if (!initialized)
{ {
initialized = true; initialized = true;
hasPrerequisites = !nowHasPrerequisites; hasPrerequisites = !nowHasPrerequisites;

2
OpenRA.Mods.Common/Widgets/Logic/ReplayBrowserLogic.cs
View File

@@ -688,7 +688,7 @@ namespace OpenRA.Mods.Common.Widgets.Logic
foreach (var replay in replays) foreach (var replay in replays)
replayState[replay].Visible = EvaluateReplayVisibility(replay); replayState[replay].Visible = EvaluateReplayVisibility(replay);
if (selectedReplay == null || replayState[selectedReplay].Visible == false) if (selectedReplay == null || !replayState[selectedReplay].Visible)
SelectFirstVisibleReplay(); SelectFirstVisibleReplay();
replayList.Layout.AdjustChildren(); replayList.Layout.AdjustChildren();